Re: [PATCH] pgweb: auth.py: make it possible to customize email address in error message

public inbox for pgsql-www@postgresql.org  
help / color / mirror / Atom feed

From: Magnus Hagander <magnus@hagander.net>
To: Célestin Matte <celestin.matte@cmatte.me>
Cc: pgsql-www@postgresql.org
Subject: Re: [PATCH] pgweb: auth.py: make it possible to customize email address in error message
Date: Mon, 1 Dec 2025 21:14:11 +0100
Message-ID: <CABUevEwTbnzYycjxUG+biuZ7Zxcf4yeYLPOx876VPk7Aqcji3w@mail.gmail.com> (raw)
In-Reply-To: <ae313e50-5ae1-4285-af2b-9d4b48b2f76a@cmatte.me>
References: <79ee1e4d-ef04-414e-a5e0-1732590ff763@cmatte.me>
	<CABUevEyjvzTA8QXjsd_-0bmxxR5--LEUWvPfXTiN7+fYoaLcZg@mail.gmail.com>
	<ae313e50-5ae1-4285-af2b-9d4b48b2f76a@cmatte.me>

On Thu, 21 Dec 2023 at 18:39, Célestin Matte <celestin.matte@cmatte.me>
wrote:

> > Maybe the correct choice is to actually add it to pglister?
>
> Alright, patched for pglister attached.
> Also attached a patch for pgarchives, because while ADMINS is defined,
> there is no default value. (Note: this variable is only used for auth.py)
>

Once again sorry to be ridiculously late :)

Realizing that this auth.py code is shared along basically all
postgresql.org properties, I think the conditional way is the right way to
do it. I don't think we should prepopulate a  value of
webmaster@postgresql.org into the ADMIN values in the configs -- but we
should add an empty one. so I've pushed that change for now.

//Magnus

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-www@postgresql.org
  Cc: magnus@hagander.net, celestin.matte@cmatte.me
  Subject: Re: [PATCH] pgweb: auth.py: make it possible to customize email address in error message
  In-Reply-To: <CABUevEwTbnzYycjxUG+biuZ7Zxcf4yeYLPOx876VPk7Aqcji3w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox