MIME-Version: 1.0
References: <79ee1e4d-ef04-414e-a5e0-1732590ff763@cmatte.me>
 <CABUevEyjvzTA8QXjsd_-0bmxxR5--LEUWvPfXTiN7+fYoaLcZg@mail.gmail.com>
 <ae313e50-5ae1-4285-af2b-9d4b48b2f76a@cmatte.me>
In-Reply-To: <ae313e50-5ae1-4285-af2b-9d4b48b2f76a@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Mon, 1 Dec 2025 21:14:11 +0100
Message-ID: 
 <CABUevEwTbnzYycjxUG+biuZ7Zxcf4yeYLPOx876VPk7Aqcji3w@mail.gmail.com>
Subject: Re: [PATCH] pgweb: auth.py: make it possible to customize email
 address in error message
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>
Cc: pgsql-www@postgresql.org
Content-Type: multipart/alternative; boundary="00000000000005ec390644e9a05d"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEwTbnzYycjxUG%2BbiuZ7Zxcf4yeYLPOx876VPk7Aqcji3w%40mail.gmail.com>
Precedence: bulk

--00000000000005ec390644e9a05d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 21 Dec 2023 at 18:39, C=C3=A9lestin Matte <celestin.matte@cmatte.me=
>
wrote:

> > Maybe the correct choice is to actually add it to pglister?
>
> Alright, patched for pglister attached.
> Also attached a patch for pgarchives, because while ADMINS is defined,
> there is no default value. (Note: this variable is only used for auth.py)
>

Once again sorry to be ridiculously late :)

Realizing that this auth.py code is shared along basically all
postgresql.org properties, I think the conditional way is the right way to
do it. I don't think we should prepopulate a  value of
webmaster@postgresql.org into the ADMIN values in the configs -- but we
should add an empty one. so I've pushed that change for now.

//Magnus

--00000000000005ec390644e9a05d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, 21 Dec =
2023 at 18:39, C=C3=A9lestin Matte &lt;<a href=3D"mailto:celestin.matte@cma=
tte.me">celestin.matte@cmatte.me</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">&gt; Maybe the correct choice is to actual=
ly add it to pglister?<br>
<br>
Alright, patched for pglister attached.<br>
Also attached a patch for pgarchives, because while ADMINS is defined, ther=
e is no default value. (Note: this variable is only used for auth.py)<br></=
blockquote><div><br></div><div>Once again sorry to be ridiculously late :)<=
/div><div><br></div><div>Realizing that this auth.py code is shared along b=
asically all <a href=3D"http://postgresql.org">postgresql.org</a> propertie=
s, I think the conditional way is the right way to do it. I don&#39;t think=
 we should prepopulate a=C2=A0 value of <a href=3D"mailto:webmaster@postgre=
sql.org">webmaster@postgresql.org</a> into the ADMIN values in the configs =
-- but we should add an empty one. so I&#39;ve pushed that change for now.<=
/div><div><br></div><div>//Magnus</div><div><br></div></div><div dir=3D"ltr=
" class=3D"gmail_signature"><div dir=3D"ltr"></div></div></div>

--00000000000005ec390644e9a05d--