public inbox for pgsql-www@postgresql.org  

help / color / mirror / Atom feed

From: Magnus Hagander <magnus@hagander.net>
To: Célestin Matte <celestin.matte@cmatte.me>
Cc: pgsql-www@postgresql.org
Subject: Re: [PATCH] pgweb: auth.py: make it possible to customize email address in error message
Date: Wed, 20 Dec 2023 20:16:30 +0100
Message-ID: <CABUevEyjvzTA8QXjsd_-0bmxxR5--LEUWvPfXTiN7+fYoaLcZg@mail.gmail.com> (raw)
In-Reply-To: <79ee1e4d-ef04-414e-a5e0-1732590ff763@cmatte.me>
References: <79ee1e4d-ef04-414e-a5e0-1732590ff763@cmatte.me>

On Tue, Dec 19, 2023 at 5:51 PM Célestin Matte <celestin.matte@cmatte.me> wrote:
>
> auth.py contains an error message with an hardcoded @postgresql.org email address.
> This patch makes it possible to change it using a variable in the settings.
> I used ADMINS because it already exists in pgweb with the correct value (and pgarchives), but that can be discussed as it doesn't exist in pglister.

Maybe the correct choice is to actually add it to pglister?

That said, having a fallback is probably still a good idea since we
have loads of servers that run this auth.py plugin, but for the
pglister specific thing I think that would be a reasonable thing to
expect?

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-www@postgresql.org
  Cc: magnus@hagander.net, celestin.matte@cmatte.me
  Subject: Re: [PATCH] pgweb: auth.py: make it possible to customize email address in error message
  In-Reply-To: <CABUevEyjvzTA8QXjsd_-0bmxxR5--LEUWvPfXTiN7+fYoaLcZg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox