MIME-Version: 1.0
References: <79ee1e4d-ef04-414e-a5e0-1732590ff763@cmatte.me>
In-Reply-To: <79ee1e4d-ef04-414e-a5e0-1732590ff763@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Wed, 20 Dec 2023 20:16:30 +0100
Message-ID: 
 <CABUevEyjvzTA8QXjsd_-0bmxxR5--LEUWvPfXTiN7+fYoaLcZg@mail.gmail.com>
Subject: Re: [PATCH] pgweb: auth.py: make it possible to customize email
 address in error message
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>
Cc: pgsql-www@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEyjvzTA8QXjsd_-0bmxxR5--LEUWvPfXTiN7%2BfYoaLcZg%40mail.gmail.com>
Precedence: bulk

On Tue, Dec 19, 2023 at 5:51=E2=80=AFPM C=C3=A9lestin Matte <celestin.matte=
@cmatte.me> wrote:
>
> auth.py contains an error message with an hardcoded @postgresql.org email=
 address.
> This patch makes it possible to change it using a variable in the setting=
s.
> I used ADMINS because it already exists in pgweb with the correct value (=
and pgarchives), but that can be discussed as it doesn't exist in pglister.

Maybe the correct choice is to actually add it to pglister?

That said, having a fallback is probably still a good idea since we
have loads of servers that run this auth.py plugin, but for the
pglister specific thing I think that would be a reasonable thing to
expect?

--=20
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/