public inbox for pgsql-www@postgresql.org  
help / color / mirror / Atom feed
From: Célestin Matte <celestin.matte@cmatte.me>
To: Magnus Hagander <magnus@hagander.net>
To: pgsql-www@postgresql.org
Subject: Re: [PATCH] pgweb: auth.py: make it possible to customize email address in error message
Date: Thu, 21 Dec 2023 18:39:15 +0100
Message-ID: <ae313e50-5ae1-4285-af2b-9d4b48b2f76a@cmatte.me> (raw)
In-Reply-To: <CABUevEyjvzTA8QXjsd_-0bmxxR5--LEUWvPfXTiN7+fYoaLcZg@mail.gmail.com>
References: <79ee1e4d-ef04-414e-a5e0-1732590ff763@cmatte.me>
	<CABUevEyjvzTA8QXjsd_-0bmxxR5--LEUWvPfXTiN7+fYoaLcZg@mail.gmail.com>

> Maybe the correct choice is to actually add it to pglister?

Alright, patched for pglister attached.
Also attached a patch for pgarchives, because while ADMINS is defined, there is no default value. (Note: this variable is only used for auth.py)

-- 
Célestin Matte


Attachments:

  [text/x-patch] 0001-Add-ADMINS-to-settings.py-for-error-message-in-auth..patch (783B, 2-0001-Add-ADMINS-to-settings.py-for-error-message-in-auth..patch)
  download | inline diff:
From 60c26a951a459393e45e13eb8544cfec67737013 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9lestin=20Matte?= <dev@cmatte.me>
Date: Thu, 21 Dec 2023 18:32:28 +0100
Subject: [PATCH] Add ADMINS to settings.py for error message in auth.py

---
 web/pglister/settings.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/web/pglister/settings.py b/web/pglister/settings.py
index 122768d..243115f 100644
--- a/web/pglister/settings.py
+++ b/web/pglister/settings.py
@@ -14,6 +14,10 @@ https://docs.djangoproject.com/en/1.8/ref/settings/
 import os
 import sys
 
+ADMINS = (
+    ('PostgreSQL Webmaster', 'webmaster@postgresql.org'),
+)
+
 BASE_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
 
 # Import the shared lib directory with non-django stuff
-- 
2.43.0



  [text/x-patch] 0001-Give-default-value-to-ADMINS-in-settings.py-for-erro.patch (724B, 3-0001-Give-default-value-to-ADMINS-in-settings.py-for-erro.patch)
  download | inline diff:
From a7607c761e7ac28b9b59aa6075eef795b76797c1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9lestin=20Matte?= <dev@cmatte.me>
Date: Thu, 21 Dec 2023 18:35:49 +0100
Subject: [PATCH] Give default value to ADMINS in settings.py for error message
 in auth.py

---
 django/archives/settings.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/django/archives/settings.py b/django/archives/settings.py
index 24861a9..97f17cf 100644
--- a/django/archives/settings.py
+++ b/django/archives/settings.py
@@ -4,7 +4,7 @@ DEBUG = True
 TEMPLATE_DEBUG = DEBUG
 
 ADMINS = (
-    # ('Your Name', 'your_email@example.com'),
+    ('PostgreSQL Webmaster', 'webmaster@postgresql.org'),
 )
 
 MANAGERS = ADMINS
-- 
2.43.0



reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-www@postgresql.org
  Cc: celestin.matte@cmatte.me, magnus@hagander.net
  Subject: Re: [PATCH] pgweb: auth.py: make it possible to customize email address in error message
  In-Reply-To: <ae313e50-5ae1-4285-af2b-9d4b48b2f76a@cmatte.me>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox