public inbox for pgsql-www@postgresql.org
help / color / mirror / Atom feedFrom: Dave Page <dpage@pgadmin.org>
To: Jonathan S. Katz <jkatz@postgresql.org>
Cc: Álvaro Herrera <alvherre@kurilemu.de>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Subject: Re: News review in dark mode
Date: Fri, 28 Nov 2025 08:55:39 +0000
Message-ID: <CA+OCxoz1oTcN9sJ4nAUwuvqPwr4yskZEYDVeyaCBctf-5tnqZg@mail.gmail.com> (raw)
In-Reply-To: <c2458bae-3056-46ae-956f-abc1127e38d4@postgresql.org>
References: <202511261449.s7ij3hueoe5r@alvherre.pgsql>
<c2458bae-3056-46ae-956f-abc1127e38d4@postgresql.org>
On Thu, 27 Nov 2025 at 16:04, Jonathan S. Katz <jkatz@postgresql.org> wrote:
> On 11/26/25 9:50 AM, Álvaro Herrera wrote:
> > On 2025-Nov-26, Dave Page wrote:
> >
> >> It's bugged me for ages that the news preview in dark mode has been
> broken
> >> forever. Here's a patch to fix that, along with before/after
> screenshots.
> >
> > Oh, yes _please_, thank you very much.
>
> +1 for the feature.
>
> Code overall looks fine to me. I'd prefer if we could make the
> "try/catch" block be more discerning about opting to ignore the
> Cross-Origin error, but given the contents of the try block are benign,
> I wouldn't block the patch on that.
>
Thanks - this has been pushed with a minor tweak to the catch block:
} catch (e) {
/* Only ignore SecurityError/cross-origin errors, rethrow
others */
if (e.name !== 'SecurityError') {
throw e;
}
}
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-www@postgresql.org
Cc: dpage@pgadmin.org, jkatz@postgresql.org, alvherre@kurilemu.de, pgsql-www@lists.postgresql.org
Subject: Re: News review in dark mode
In-Reply-To: <CA+OCxoz1oTcN9sJ4nAUwuvqPwr4yskZEYDVeyaCBctf-5tnqZg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox