MIME-Version: 1.0
References: <202511261449.s7ij3hueoe5r@alvherre.pgsql>
 <c2458bae-3056-46ae-956f-abc1127e38d4@postgresql.org>
In-Reply-To: <c2458bae-3056-46ae-956f-abc1127e38d4@postgresql.org>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 28 Nov 2025 08:55:39 +0000
Message-ID: 
 <CA+OCxoz1oTcN9sJ4nAUwuvqPwr4yskZEYDVeyaCBctf-5tnqZg@mail.gmail.com>
Subject: Re: News review in dark mode
To: "Jonathan S. Katz" <jkatz@postgresql.org>
Cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000d8e07d0644a3cb93"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BOCxoz1oTcN9sJ4nAUwuvqPwr4yskZEYDVeyaCBctf-5tnqZg%40mail.gmail.com>
Precedence: bulk

--000000000000d8e07d0644a3cb93
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 27 Nov 2025 at 16:04, Jonathan S. Katz <jkatz@postgresql.org> wrote=
:

> On 11/26/25 9:50 AM, =C3=81lvaro Herrera wrote:
> > On 2025-Nov-26, Dave Page wrote:
> >
> >> It's bugged me for ages that the news preview in dark mode has been
> broken
> >> forever. Here's a patch to fix that, along with before/after
> screenshots.
> >
> > Oh, yes _please_, thank you very much.
>
> +1 for the feature.
>
> Code overall looks fine to me. I'd prefer if we could make the
> "try/catch" block be more discerning about opting to ignore the
> Cross-Origin error, but given the contents of the try block are benign,
> I wouldn't block the patch on that.
>

Thanks - this has been pushed with a minor tweak to the catch block:

            } catch (e) {
                /* Only ignore SecurityError/cross-origin errors, rethrow
others */
                if (e.name !=3D=3D 'SecurityError') {
                    throw e;
                }
            }

--=20
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com

--000000000000d8e07d0644a3cb93
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, 27 Nov =
2025 at 16:04, Jonathan S. Katz &lt;<a href=3D"mailto:jkatz@postgresql.org"=
>jkatz@postgresql.org</a>&gt; wrote:<br></div><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-st=
yle:solid;border-left-color:rgb(204,204,204);padding-left:1ex">On 11/26/25 =
9:50 AM, =C3=81lvaro Herrera wrote:<br>
&gt; On 2025-Nov-26, Dave Page wrote:<br>
&gt; <br>
&gt;&gt; It&#39;s bugged me for ages that the news preview in dark mode has=
 been broken<br>
&gt;&gt; forever. Here&#39;s a patch to fix that, along with before/after s=
creenshots.<br>
&gt; <br>
&gt; Oh, yes _please_, thank you very much.<br>
<br>
+1 for the feature.<br>
<br>
Code overall looks fine to me. I&#39;d prefer if we could make the <br>
&quot;try/catch&quot; block be more discerning about opting to ignore the <=
br>
Cross-Origin error, but given the contents of the try block are benign, <br=
>
I wouldn&#39;t block the patch on that.<br></blockquote><div><br></div><div=
>Thanks - this has been pushed with a minor tweak to the catch block:</div>=
<div><br></div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } catch (e) {=
<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Only ignore =
SecurityError/cross-origin errors, rethrow others */<br>=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (<a href=3D"http://e.name">e.name=
</a> !=3D=3D &#39;SecurityError&#39;) {<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 throw e;<br>=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 }<br></div><div>=C2=A0</div></div><span class=3D"gmail_signature_prefix=
">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"=
>Dave Page<div>pgAdmin: <a href=3D"https://www.pgadmin.org" target=3D"_blan=
k">https://www.pgadmin.org</a></div><div>PostgreSQL: <a href=3D"https://www=
.postgresql.org" target=3D"_blank">https://www.postgresql.org</a></div><div=
>pgEdge: <a href=3D"https://www.pgedge.com" target=3D"_blank">https://www.p=
gedge.com</a><br><div></div><div><br></div></div></div></div></div>

--000000000000d8e07d0644a3cb93--