public inbox for pgsql-www@postgresql.org  

help / color / mirror / Atom feed

From: Jonathan S. Katz <jkatz@postgresql.org>
To: Álvaro Herrera <alvherre@kurilemu.de>
To: Dave Page <dpage@pgadmin.org>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Subject: Re: News review in dark mode
Date: Thu, 27 Nov 2025 11:04:19 -0500
Message-ID: <c2458bae-3056-46ae-956f-abc1127e38d4@postgresql.org> (raw)
In-Reply-To: <202511261449.s7ij3hueoe5r@alvherre.pgsql>
References: <202511261449.s7ij3hueoe5r@alvherre.pgsql>

On 11/26/25 9:50 AM, Álvaro Herrera wrote:
> On 2025-Nov-26, Dave Page wrote:
> 
>> It's bugged me for ages that the news preview in dark mode has been broken
>> forever. Here's a patch to fix that, along with before/after screenshots.
> 
> Oh, yes _please_, thank you very much.

+1 for the feature.

Code overall looks fine to me. I'd prefer if we could make the 
"try/catch" block be more discerning about opting to ignore the 
Cross-Origin error, but given the contents of the try block are benign, 
I wouldn't block the patch on that.

Thanks,

Jonathan


Attachments:

  [application/pgp-signature] OpenPGP_signature.asc (840B, 2-OpenPGP_signature.asc)
  download

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-www@postgresql.org
  Cc: jkatz@postgresql.org, alvherre@kurilemu.de, dpage@pgadmin.org, pgsql-www@lists.postgresql.org
  Subject: Re: News review in dark mode
  In-Reply-To: <c2458bae-3056-46ae-956f-abc1127e38d4@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox