agora inbox for postgres@postgres.berkeley.edu
help / color / mirror / Atom feedFrom: Jim Davidson <jimbo@crseo.ucsb.edu>
To: postgres@postgres.Berkeley.EDU
Subject: PGBROWSE patch
Date: Tue, 05 Jul 1994 17:38:37 -0700
Message-ID: <9407060038.AA08480@ crseo.ucsb.edu> (raw)
Hello,
The patch:
ftp://crseo.ucsb.edu/pub/pgbrowse/pgbrowse-v3.1b.patch2
fixes a problem reported by Lukas Rosenthaler <rosenthaler@urz.unibas.ch>:
If I want to append to a class using the query dialog box, the attributes in
the presented form do not correspond to the attributes used in the append
command. An example:
Let's assume a class of 3 attributes, name (char16), last_name (char16) and
phone (int). The form does present the following (ascii representation ;-) )
phone: ______________
last_name: ______________
name: _____________
oid: _______________
after filling in:
phone: 1234
last_name: Rosenthaler
name: lukas
but the append command looks like this:
append adress (
name="1234"::char16,
vorname="Rosenthaler"::char16,
telefon="lukas"::char16
)
It looks like the order has been reversed.
It turned out to be a one-line fix, the patch is included below.
Thanks to Lukas for pointing this out!
Cheers, -Jim
*** lib/browse.tcl.orig Tue Jul 05 17:17:17 1994
--- lib/browse.tcl Tue Jul 05 17:21:13 1994
***************
*** 1,7 ****
#
# browse.tcl - procedures for the top level window of PGBrowse
#
! # $Header: /home/jimbo/pgbrowse/lib/RCS/browse.tcl,v 1.1 1994/07/06 00:11:22 jimbo Exp $
#
# ---------------------------------------------------------------------------
--- 1,7 ----
#
# browse.tcl - procedures for the top level window of PGBrowse
#
! # $Header: /home/jimbo/pgbrowse/lib/RCS/browse.tcl,v 1.2 1994/07/06 00:12:38 jimbo Exp $
#
# ---------------------------------------------------------------------------
***************
*** 568,573 ****
--- 568,574 ----
and pg_attribute.atttypid = pg_type.oid
and pg_attribute.attnum > 0
and pg_class.relname = \"$class\"
+ sort by attnum
"
set msg "Opening $class..."
if ![PQ exec $cmd $msg] {
==============================================================================
To add/remove yourself to/from the POSTGRES mailing list: send mail with
the subject line ADD or DEL to "postgres-request@postgres.Berkeley.EDU"
If this fails, send mail to "post_questions@postgres.Berkeley.EDU" and
a human will deal with it. DO NOT post to the "postgres" mailing list.
==============================================================================
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: postgres@postgres.berkeley.edu
Cc: jimbo@crseo.ucsb.edu
Subject: Re: PGBROWSE patch
In-Reply-To: <9407060038.AA08480@ crseo.ucsb.edu>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox