Return-Path: owner-postman
Received: from localhost.Berkeley.EDU (localhost.Berkeley.EDU [127.0.0.1]) by nobozo.CS.Berkeley.EDU (8.6.4/8.6.3) with SMTP id RAA07145 for postgres-redist; Tue, 5 Jul 1994 17:38:48 -0700
Resent-From: POSTGRES mailing list <postman@postgres.Berkeley.EDU>
Resent-Message-Id: <199407060038.RAA07145@nobozo.CS.Berkeley.EDU>
X-Authentication-Warning: nobozo.CS.Berkeley.EDU: Host localhost.Berkeley.EDU didn't use HELO protocol
Sender: owner-postman@postgres.Berkeley.EDU
X-Return-Path: owner-postman
Received: from crseo.ucsb.edu (crseo-gw.ucsb.edu [128.111.254.100]) by nobozo.CS.Berkeley.EDU (8.6.4/8.6.3) with SMTP id RAA07135 for <postgres@postgres.berkeley.edu>; Tue, 5 Jul 1994 17:38:44 -0700
Received: by  crseo.ucsb.edu (4.1/SMI-4.4-Crseo Special)
	id AA08480; Tue, 5 Jul 94 17:38:37 PDT
Message-Id: <9407060038.AA08480@ crseo.ucsb.edu>
To: postgres@postgres.Berkeley.EDU
Subject: PGBROWSE patch
Date: Tue, 05 Jul 1994 17:38:37 -0700
From: Jim Davidson <jimbo@crseo.ucsb.edu>
Resent-To: postgres-redist@postgres.Berkeley.EDU
Resent-Date: Tue, 05 Jul 94 17:38:48 -0700
Resent-XMts: smtp


Hello,

The patch:

	ftp://crseo.ucsb.edu/pub/pgbrowse/pgbrowse-v3.1b.patch2

fixes a problem reported by Lukas Rosenthaler <rosenthaler@urz.unibas.ch>:


 If I want to append to a class using the query dialog box, the attributes in
 the presented form do not correspond to the attributes used in the append
 command. An example:
 
 Let's assume a class of 3 attributes, name (char16), last_name (char16) and
 phone (int). The form does present the following (ascii representation ;-) )
 
 	phone: 		______________
         last_name: 	______________
 	name: 		_____________
 	oid: 		_______________
 
 after filling in:
 
 	phone: 		1234
 	last_name: 	Rosenthaler
 	name: 		lukas
 
 but the append command looks like this:
 
 append adress (
 	name="1234"::char16,
 	vorname="Rosenthaler"::char16,
 	telefon="lukas"::char16
 )
 
 It looks like the order has been reversed.
 


It turned out to be a one-line fix, the patch is included below.
Thanks to Lukas for pointing this out!

Cheers, -Jim


*** lib/browse.tcl.orig	Tue Jul 05 17:17:17 1994
--- lib/browse.tcl	Tue Jul 05 17:21:13 1994
***************
*** 1,7 ****
  #
  # browse.tcl - procedures for the top level window of PGBrowse
  #
! # $Header: /home/jimbo/pgbrowse/lib/RCS/browse.tcl,v 1.1 1994/07/06 00:11:22 jimbo Exp $
  #
  
  # ---------------------------------------------------------------------------
--- 1,7 ----
  #
  # browse.tcl - procedures for the top level window of PGBrowse
  #
! # $Header: /home/jimbo/pgbrowse/lib/RCS/browse.tcl,v 1.2 1994/07/06 00:12:38 jimbo Exp $
  #
  
  # ---------------------------------------------------------------------------
***************
*** 568,573 ****
--- 568,574 ----
      and   pg_attribute.atttypid = pg_type.oid
      and   pg_attribute.attnum   > 0
      and   pg_class.relname      = \"$class\"
+     sort by attnum
  "
      set msg "Opening $class..."
      if ![PQ exec $cmd $msg] {

==============================================================================
   To add/remove yourself to/from the POSTGRES mailing list: send mail with 
   the subject line ADD or DEL to "postgres-request@postgres.Berkeley.EDU"

   If this fails, send mail to "post_questions@postgres.Berkeley.EDU" and
   a human will deal with it.  DO NOT post to the "postgres" mailing list.
==============================================================================