public inbox for pgsql-www@postgresql.org
help / color / mirror / Atom feedFrom: Akshat Jaimini <destrex271@gmail.com>
To: Célestin Matte <celestin.matte@cmatte.me>
To: pgsql-www@lists.postgresql.org
Subject: Re: [PATCH] pgweb: auth.py: make it possible to customize email address in error message
Date: Wed, 20 Dec 2023 21:35:05 +0530
Message-ID: <CAMaW3Vg5ZVFkoFrb4mv7dvDKFOfxGwvPg8OUQSGBiOm40LS=SA@mail.gmail.com> (raw)
In-Reply-To: <8267c32e-2acb-4bf9-adc0-139fa695355d@cmatte.me>
References: <79ee1e4d-ef04-414e-a5e0-1732590ff763@cmatte.me>
<CAMaW3Vh1jch_ELyV4ucGUmWqBW-6V5y26iwRe4ARJMM5y7Ut-Q@mail.gmail.com>
<8267c32e-2acb-4bf9-adc0-139fa695355d@cmatte.me>
We actually have a new tool that tests all the functionalities in the
website. So just wanted to run it through that before.
I'll run the tests against your gitlab mirror.
Checkout the harness here:
https://github.com/destrex271/pgweb-testing-harness
Regards,
Akshat Jaimini
On Wed, 20 Dec, 2023, 20:11 Célestin Matte, <celestin.matte@cmatte.me>
wrote:
> Hello,
>
> Not sure what you're asking — I don't have access to the pgweb repo
> Do you mean a pull request?
> My local copy is on gitlab:
> https://gitlab.com/cmatte/pgweb/-/tree/auth_email?ref_type=heads
>
> Regards,
>
> On 20/12/2023 14:32, Akshat Jaimini wrote:
> > Hi!
> > It would be great if we could test this patch with the testing harness
> to confirm that nothing would break(although I am sure nothing would but
> there's no harm in testing).
> >
> > Is it possible to setup a develop/testing branch on the pgweb repo from
> where the harness can pull it?
> >
> > Regards,
> > Akshat Jaimini
> >
> > On Tue, 19 Dec, 2023, 22:21 Célestin Matte, <celestin.matte@cmatte.me
> <mailto:celestin.matte@cmatte.me>> wrote:
> >
> > auth.py contains an error message with an hardcoded @postgresql.org
> <http://postgresql.org; email address.
> > This patch makes it possible to change it using a variable in the
> settings.
> > I used ADMINS because it already exists in pgweb with the correct
> value (and pgarchives), but that can be discussed as it doesn't exist in
> pglister.
> >
> > --
> > Célestin Matte
> >
>
> --
> Célestin Matte
>
>
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-www@postgresql.org
Cc: destrex271@gmail.com, celestin.matte@cmatte.me, pgsql-www@lists.postgresql.org
Subject: Re: [PATCH] pgweb: auth.py: make it possible to customize email address in error message
In-Reply-To: <CAMaW3Vg5ZVFkoFrb4mv7dvDKFOfxGwvPg8OUQSGBiOm40LS=SA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox