MIME-Version: 1.0
References: <79ee1e4d-ef04-414e-a5e0-1732590ff763@cmatte.me>
 <CAMaW3Vh1jch_ELyV4ucGUmWqBW-6V5y26iwRe4ARJMM5y7Ut-Q@mail.gmail.com>
 <8267c32e-2acb-4bf9-adc0-139fa695355d@cmatte.me>
In-Reply-To: <8267c32e-2acb-4bf9-adc0-139fa695355d@cmatte.me>
From: Akshat Jaimini <destrex271@gmail.com>
Date: Wed, 20 Dec 2023 21:35:05 +0530
Message-ID: 
 <CAMaW3Vg5ZVFkoFrb4mv7dvDKFOfxGwvPg8OUQSGBiOm40LS=SA@mail.gmail.com>
Subject: Re: [PATCH] pgweb: auth.py: make it possible to customize email
 address in error message
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>,
	pgsql-www@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000448990060cf32685"
Archived-At: 
 <https://www.postgresql.org/message-id/CAMaW3Vg5ZVFkoFrb4mv7dvDKFOfxGwvPg8OUQSGBiOm40LS%3DSA%40mail.gmail.com>
Precedence: bulk

--000000000000448990060cf32685
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

We actually have a new tool that tests all the functionalities in the
website. So just wanted to run it through that before.

I'll run the tests against your gitlab mirror.

Checkout the harness here:
https://github.com/destrex271/pgweb-testing-harness


Regards,
Akshat Jaimini

On Wed, 20 Dec, 2023, 20:11 C=C3=A9lestin Matte, <celestin.matte@cmatte.me>
wrote:

> Hello,
>
> Not sure what you're asking =E2=80=94 I don't have access to the pgweb re=
po
> Do you mean a pull request?
> My local copy is on gitlab:
> https://gitlab.com/cmatte/pgweb/-/tree/auth_email?ref_type=3Dheads
>
> Regards,
>
> On 20/12/2023 14:32, Akshat Jaimini wrote:
> > Hi!
> > It would be great if we could test this patch with the testing harness
> to confirm that nothing would break(although I am sure nothing would but
> there's no harm in testing).
> >
> > Is it possible to setup a develop/testing branch on the pgweb repo from
> where the harness can pull it?
> >
> > Regards,
> > Akshat Jaimini
> >
> > On Tue, 19 Dec, 2023, 22:21 C=C3=A9lestin Matte, <celestin.matte@cmatte=
.me
> <mailto:celestin.matte@cmatte.me>> wrote:
> >
> >     auth.py contains an error message with an hardcoded @postgresql.org
> <http://postgresql.org> email address.
> >     This patch makes it possible to change it using a variable in the
> settings.
> >     I used ADMINS because it already exists in pgweb with the correct
> value (and pgarchives), but that can be discussed as it doesn't exist in
> pglister.
> >
> >     --
> >     C=C3=A9lestin Matte
> >
>
> --
> C=C3=A9lestin Matte
>
>

--000000000000448990060cf32685
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">We actually have a new tool that tests all the functional=
ities in the website. So just wanted to run it through that before.<div dir=
=3D"auto"><br></div><div dir=3D"auto">I&#39;ll run the tests against your g=
itlab mirror.</div><div dir=3D"auto"><br></div><div dir=3D"auto">Checkout t=
he harness here:=C2=A0<a href=3D"https://github.com/destrex271/pgweb-testin=
g-harness">https://github.com/destrex271/pgweb-testing-harness</a></div><di=
v dir=3D"auto"><br></div><div dir=3D"auto"><br></div><div dir=3D"auto">Rega=
rds,</div><div dir=3D"auto">Akshat Jaimini</div></div><br><div class=3D"gma=
il_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, 20 Dec, 2023, 20:11=
 C=C3=A9lestin Matte, &lt;<a href=3D"mailto:celestin.matte@cmatte.me">celes=
tin.matte@cmatte.me</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quot=
e" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">=
Hello,<br>
<br>
Not sure what you&#39;re asking =E2=80=94 I don&#39;t have access to the pg=
web repo<br>
Do you mean a pull request?<br>
My local copy is on gitlab: <a href=3D"https://gitlab.com/cmatte/pgweb/-/tr=
ee/auth_email?ref_type=3Dheads" rel=3D"noreferrer noreferrer" target=3D"_bl=
ank">https://gitlab.com/cmatte/pgweb/-/tree/auth_email?ref_type=3Dheads</a>=
<br>
<br>
Regards,<br>
<br>
On 20/12/2023 14:32, Akshat Jaimini wrote:<br>
&gt; Hi!<br>
&gt; It would be great if we could test this patch with the testing harness=
 to confirm that nothing would break(although I am sure nothing would but t=
here&#39;s no harm in testing).<br>
&gt; <br>
&gt; Is it possible to setup a develop/testing branch on the pgweb repo fro=
m where the harness can pull it?<br>
&gt; <br>
&gt; Regards,<br>
&gt; Akshat Jaimini<br>
&gt; <br>
&gt; On Tue, 19 Dec, 2023, 22:21 C=C3=A9lestin Matte, &lt;<a href=3D"mailto=
:celestin.matte@cmatte.me" target=3D"_blank" rel=3D"noreferrer">celestin.ma=
tte@cmatte.me</a> &lt;mailto:<a href=3D"mailto:celestin.matte@cmatte.me" ta=
rget=3D"_blank" rel=3D"noreferrer">celestin.matte@cmatte.me</a>&gt;&gt; wro=
te:<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0auth.py contains an error message with an hardcoded=
 @<a href=3D"http://postgresql.org" rel=3D"noreferrer noreferrer" target=3D=
"_blank">postgresql.org</a> &lt;<a href=3D"http://postgresql.org" rel=3D"no=
referrer noreferrer" target=3D"_blank">http://postgresql.org</a>&gt; email =
address.<br>
&gt;=C2=A0 =C2=A0 =C2=A0This patch makes it possible to change it using a v=
ariable in the settings.<br>
&gt;=C2=A0 =C2=A0 =C2=A0I used ADMINS because it already exists in pgweb wi=
th the correct value (and pgarchives), but that can be discussed as it does=
n&#39;t exist in pglister.<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0-- <br>
&gt;=C2=A0 =C2=A0 =C2=A0C=C3=A9lestin Matte<br>
&gt; <br>
<br>
-- <br>
C=C3=A9lestin Matte<br>
<br>
</blockquote></div>

--000000000000448990060cf32685--