public inbox for pgsql-hackers@postgresql.org  

help / color / mirror / Atom feed

From: Nitin Motiani <nitinmotiani@google.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Hannu Krosing <hannuk@google.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Adding pg_dump flag for parallel export to pipes
Date: Mon, 28 Apr 2025 13:52:53 +0530
Message-ID: <CAH5HC94_Miqg9wnu=wFBrDR0q97aE6-VO_A3ObPHTMQ5Xjki2g@mail.gmail.com> (raw)
In-Reply-To: <CA+hUKGLL5o6hc4ZPvy=JMuFSKksQiqo0PfSsT5Kr2e30Pag8Hw@mail.gmail.com>
References: <CAH5HC97p4kkpikar+swuC0Lx4YTVkE30sTsFX94tyzih7Cc_=w@mail.gmail.com>
	<CAMT0RQRPJUVsZbv6B=G6ccoZ+OM2vPOG85B6xDd+vKR6-0wt0g@mail.gmail.com>
	<CA+hUKGLL5o6hc4ZPvy=JMuFSKksQiqo0PfSsT5Kr2e30Pag8Hw@mail.gmail.com>

Thanks for the feedback, Thomas.

> No comment on the wider project except that it looks generally useful,
> and I can see that it's not possible to use the conventional POSIX
> filename "-" to represent stdout, because you need to write to
> multiple files so you need to come up with *something* along the lines
> you're proposing here.  But I was interested in seeing if I could help
> with that technical problem you mentioned above, and I don't see that
> happening with the current patches.  Do I understand correctly that
> the problem you encountered is in some other tests that you haven't
> attached yet?  Could you post what you have so that others can see the
> problem and perhaps have a chance of helping?

Yes, we didn't add the failed tests to the patch. We'll add those and
send new patches.

> I also recommend using
> git format-patch when you post patches so that you have a place to
> write a commit message including a note about which bits are WIP and
> known not to work correctly yet.

Will follow these recommendations when sending the next set of patches.

Regards,
Nitin Motiani
Google

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nitinmotiani@google.com, thomas.munro@gmail.com, hannuk@google.com
  Subject: Re: Adding pg_dump flag for parallel export to pipes
  In-Reply-To: <CAH5HC94_Miqg9wnu=wFBrDR0q97aE6-VO_A3ObPHTMQ5Xjki2g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox