public inbox for pgsql-hackers@postgresql.org  

help / color / mirror / Atom feed

From: Thomas Munro <thomas.munro@gmail.com>
To: Hannu Krosing <hannuk@google.com>
Cc: pgsql-hackers@postgresql.org
Cc: Nitin Motiani <nitinmotiani@google.com>
Subject: Re: Adding pg_dump flag for parallel export to pipes
Date: Sat, 26 Apr 2025 13:07:09 +1200
Message-ID: <CA+hUKGLL5o6hc4ZPvy=JMuFSKksQiqo0PfSsT5Kr2e30Pag8Hw@mail.gmail.com> (raw)
In-Reply-To: <CAMT0RQRPJUVsZbv6B=G6ccoZ+OM2vPOG85B6xDd+vKR6-0wt0g@mail.gmail.com>
References: <CAH5HC97p4kkpikar+swuC0Lx4YTVkE30sTsFX94tyzih7Cc_=w@mail.gmail.com>
	<CAMT0RQRPJUVsZbv6B=G6ccoZ+OM2vPOG85B6xDd+vKR6-0wt0g@mail.gmail.com>

On Tue, Apr 8, 2025 at 7:48 AM Hannu Krosing <hannuk@google.com> wrote:
> Just to bring this out separately : Does anybody have any idea why pipe commands close inside tests ?
>
> Re: 003-pg_dump_basic_tests has a few basic validation tests for
> correctmflag combinations. We need to write more automated tests in
> 002_pg_dump.pl but have been running into some issues with environment
> setup due to which certain pipe commands result in the shell process
> becoming defunct. These same commands are working fine in manual
> testing. We are still looking into this.

No comment on the wider project except that it looks generally useful,
and I can see that it's not possible to use the conventional POSIX
filename "-" to represent stdout, because you need to write to
multiple files so you need to come up with *something* along the lines
you're proposing here.  But I was interested in seeing if I could help
with that technical problem you mentioned above, and I don't see that
happening with the current patches.  Do I understand correctly that
the problem you encountered is in some other tests that you haven't
attached yet?  Could you post what you have so that others can see the
problem and perhaps have a chance of helping?  I also recommend using
git format-patch when you post patches so that you have a place to
write a commit message including a note about which bits are WIP and
known not to work correctly yet.

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: thomas.munro@gmail.com, hannuk@google.com, nitinmotiani@google.com
  Subject: Re: Adding pg_dump flag for parallel export to pipes
  In-Reply-To: <CA+hUKGLL5o6hc4ZPvy=JMuFSKksQiqo0PfSsT5Kr2e30Pag8Hw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox