MIME-Version: 1.0
References: <281f9ff6-62fd-45fa-9396-0dbf1b4abae0@cmatte.me>
 <6127117d-6490-4dee-a5ce-d8d17b65a717@cmatte.me>
In-Reply-To: <6127117d-6490-4dee-a5ce-d8d17b65a717@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Mon, 1 Dec 2025 20:56:21 +0100
Message-ID: 
 <CABUevEzt6g0wsNoEciHJo1kqZGxCc47NrzuBHCvWQoihsVrj3Q@mail.gmail.com>
Subject: Re: [PATCH] pgarchives: bugfix: increase listsubscription username
 length
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000004c699e0644e960be"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEzt6g0wsNoEciHJo1kqZGxCc47NrzuBHCvWQoihsVrj3Q%40mail.gmail.com>
Precedence: bulk

--0000000000004c699e0644e960be
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi!

Better late than never, this has been pushed. Sorry about the delay!

//Magnus

On Mon, 22 Sept 2025 at 21:28, C=C3=A9lestin Matte <celestin.matte@cmatte.m=
e>
wrote:

> Correction: the field is copied from auth_user.username, which is max 150
> characters:
> https://docs.djangoproject.com/en/5.2/ref/contrib/auth/#django.contrib.au=
th.models.User.username
>
> Corrected patch attached
>
> On 22/09/2025 21:13, C=C3=A9lestin Matte wrote:
> > The listsubscription username field is populated by pglister_sync,
> > copying information from auth_user.email, which can be up to
> > 254 characters.
> > If a user defined an email address that is longer than 30
> > characters, pglister_sync will crash:
> >
> > Traceback (most recent call last):
> >    File "/path/pglister_sync.py", line 83, in <module>
> >      curs.execute("WITH t(u) AS (SELECT UNNEST(%(usernames)s::text[])),
> ins(un) AS (INSERT INTO listsubscribers (username, list_id) SELECT u,
> %(listid)s FROM t WHERE NOT EXISTS (SELECT 1 FROM listsubscribers WHERE
> username=3Du AND list_id=3D%(listid)s) RETURNING username), del(un) AS (D=
ELETE
> FROM listsubscribers WHERE list_id=3D%(listid)s AND NOT EXISTS (SELECT 1 =
FROM
> t WHERE u=3Dusername) RETURNING username) SELECT 'ins',un FROM ins UNION =
ALL
> SELECT 'del',un FROM del ORDER BY 1,2", {
> > psycopg2.errors.StringDataRightTruncation: value too long for type
> character varying(30)
> >
> > This patch fixes the issue by using the same max length as any
> > django email field for this field.
>
>
> --
> C=C3=A9lestin Matte

--0000000000004c699e0644e960be
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi!</div><div><br></div><div>Better late than never, =
this has been pushed. Sorry about the delay!</div><div><br></div><div>//Mag=
nus</div><br><div class=3D"gmail_quote gmail_quote_container"><div dir=3D"l=
tr" class=3D"gmail_attr">On Mon, 22 Sept 2025 at 21:28, C=C3=A9lestin Matte=
 &lt;<a href=3D"mailto:celestin.matte@cmatte.me">celestin.matte@cmatte.me</=
a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0p=
x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Co=
rrection: the field is copied from auth_user.username, which is max 150 cha=
racters: <a href=3D"https://docs.djangoproject.com/en/5.2/ref/contrib/auth/=
#django.contrib.auth.models.User.username" rel=3D"noreferrer" target=3D"_bl=
ank">https://docs.djangoproject.com/en/5.2/ref/contrib/auth/#django.contrib=
.auth.models.User.username</a><br>
<br>
Corrected patch attached<br>
<br>
On 22/09/2025 21:13, C=C3=A9lestin Matte wrote:<br>
&gt; The listsubscription username field is populated by pglister_sync,<br>
&gt; copying information from auth_user.email, which can be up to<br>
&gt; 254 characters.<br>
&gt; If a user defined an email address that is longer than 30<br>
&gt; characters, pglister_sync will crash:<br>
&gt; <br>
&gt; Traceback (most recent call last):<br>
&gt;=C2=A0 =C2=A0 File &quot;/path/pglister_sync.py&quot;, line 83, in &lt;=
module&gt;<br>
&gt;=C2=A0 =C2=A0=C2=A0=C2=A0 curs.execute(&quot;WITH t(u) AS (SELECT UNNES=
T(%(usernames)s::text[])), ins(un) AS (INSERT INTO listsubscribers (usernam=
e, list_id) SELECT u, %(listid)s FROM t WHERE NOT EXISTS (SELECT 1 FROM lis=
tsubscribers WHERE username=3Du AND list_id=3D%(listid)s) RETURNING usernam=
e), del(un) AS (DELETE FROM listsubscribers WHERE list_id=3D%(listid)s AND =
NOT EXISTS (SELECT 1 FROM t WHERE u=3Dusername) RETURNING username) SELECT =
&#39;ins&#39;,un FROM ins UNION ALL SELECT &#39;del&#39;,un FROM del ORDER =
BY 1,2&quot;, {<br>
&gt; psycopg2.errors.StringDataRightTruncation: value too long for type cha=
racter varying(30)<br>
&gt; <br>
&gt; This patch fixes the issue by using the same max length as any<br>
&gt; django email field for this field.<br>
<br>
<br>
-- <br>
C=C3=A9lestin Matte</blockquote></div><div><br></div><div dir=3D"ltr" class=
=3D"gmail_signature"><div dir=3D"ltr"></div></div></div>

--0000000000004c699e0644e960be--