MIME-Version: 1.0
References: <b39abaaf-00f0-47b9-b819-3b22d83a67d8@cmatte.me>
In-Reply-To: <b39abaaf-00f0-47b9-b819-3b22d83a67d8@cmatte.me>
From: Magnus Hagander <magnus@hagander.net>
Date: Mon, 1 Dec 2025 21:00:47 +0100
Message-ID: 
 <CABUevEyGraEg-z_602j8oukikOYy05j-Raxgt8Ndi3WGsi069Q@mail.gmail.com>
Subject: Re: pglister: pgarchives does not synchronize subscribers with email
 delivery disabled (proposed patch)
To: =?UTF-8?Q?C=C3=A9lestin_Matte?= <contact@cmatte.me>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000025bda20644e9708c"
Archived-At: 
 <https://www.postgresql.org/message-id/CABUevEyGraEg-z_602j8oukikOYy05j-Raxgt8Ndi3WGsi069Q%40mail.gmail.com>
Precedence: bulk

--00000000000025bda20644e9708c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 22 Sept 2025 at 20:18, C=C3=A9lestin Matte <contact@cmatte.me> wrot=
e:

> The pglister_sync script is supposed to synchronize subscribers from
> pglister to pgarchives, so they can access archives.
>  From what I understand of its semantics, the "nomail" field (labeled
> "Disable mail delivery") is used to remain subscribed, to be able to acce=
ss
> archives, without receiving emails.
> However, due to the way the API works, this is not the case.
> pglister_sync.py makes a call to the API, which get subscribers from the
> mailinglist_subscribers SQL view. This view is built in the
> 0027_merge_migrations.py migrations and excludes users with nomail.
> I propose a patch with a migration to change this SQL view to include
> nomail users (copying previous definition, without "AND NOT nomail").
> Note that this changes results of the API, which might have consequences
> if other scripts use it (I haven't found any with some grepping).
>

Hi!

mailinglist_subscribers is used for actual mail delivery as well, isn't it?
If you just change the view, it will change all deliveries and basically
the nomail switch to not work at all?

While you're on the right track to include them, don't we also need to
include the nomail column as a column in the view and then filter on that
when sending email?

//Magnus

--00000000000025bda20644e9708c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, 22 Sept=
 2025 at 20:18, C=C3=A9lestin Matte &lt;<a href=3D"mailto:contact@cmatte.me=
">contact@cmatte.me</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">The pglister_sync script is supposed to synchronize subs=
cribers from pglister to pgarchives, so they can access archives.<br>
=C2=A0From what I understand of its semantics, the &quot;nomail&quot; field=
 (labeled &quot;Disable mail delivery&quot;) is used to remain subscribed, =
to be able to access archives, without receiving emails.<br>
However, due to the way the API works, this is not the case. pglister_sync.=
py makes a call to the API, which get subscribers from the mailinglist_subs=
cribers SQL view. This view is built in the 0027_merge_migrations.py migrat=
ions and excludes users with nomail.<br>
I propose a patch with a migration to change this SQL view to include nomai=
l users (copying previous definition, without &quot;AND NOT nomail&quot;).<=
br>
Note that this changes results of the API, which might have consequences if=
 other scripts use it (I haven&#39;t found any with some grepping).<br></bl=
ockquote><div><br></div><div>Hi!</div><div><br></div><div>mailinglist_subsc=
ribers is used for actual mail delivery as well, isn&#39;t it? If you just =
change the view, it will change all deliveries and basically the nomail swi=
tch to not work at all?</div><div><br></div><div>While you&#39;re on the ri=
ght track to include them, don&#39;t we also need to include the nomail col=
umn as a column in the view and then filter on that when sending email?</di=
v><div><br></div><div>//Magnus</div></div><div dir=3D"ltr" class=3D"gmail_s=
ignature"><div dir=3D"ltr"></div></div></div>

--00000000000025bda20644e9708c--