public inbox for pgsql-www@postgresql.org  
help / color / mirror / Atom feed
From: Tobias Bussmann <t.bussmann@gmx.net>
To: Jonathan S. Katz <jkatz@postgresql.org>
To: pgsql-www@lists.postgresql.org
Subject: Re: Images in news mails
Date: Sun, 7 Sep 2025 18:16:27 +0200
Message-ID: <4C210077-20E5-415C-8A69-B82331A42B9A@gmx.net> (raw)
In-Reply-To: <29c71778-5871-4e4d-a80e-d67351c8eb4b@postgresql.org>
References: <99A6E7C8-1634-4162-96FD-D5AC404ADBCF@gmx.net>
	<29c71778-5871-4e4d-a80e-d67351c8eb4b@postgresql.org>

Am 05.09.2025 um 20:23 schrieb Jonathan S. Katz <jkatz@postgresql.org>:
> This has plagued me for years, and I'm so happy you tracked this down!

I'm happy to hear, I'm not the only one seeing this. Glad to help!


> The patch looks good; have you tested in a few other mail clients? I haven't had a chance to test yet.

I haven't tried other mail clients myself, but as the style definition is just redundant to the img attributes, I wouldn't expect any regression by this. But HTML emails are full of miracles ;)

Litmus.com has become quite expensive for render previews, so I looked for alternatives. I found Testi.at, which offers some free tests at least. Unfortunately, I was unable to provide the full MIME structure there and thus could not simulate the CID-referenced image that causes the problem in Apple Mail. When I experimented with an externally hosted image, the result looked good in the provided previews. However, I visually identified another issue: Outlook does not seem to support the 'float' style attribute [1 footnote 1]. In the v2 patch, I implemented a workaround to duplicate the 'float' style using an 'align' img attribute. Previews of the resulting rendering can be found at [2].

Best
Tobias

[1]: <https://www.caniemail.com/search/?s=float;
[2]: <https://testi.at/proj/7oveul95szn3cz5as6;



Attachments:

  [application/octet-stream] 0001-fix-display-of-images-in-apple-mail-v2.patch (1.1K, 2-0001-fix-display-of-images-in-apple-mail-v2.patch)
  download | inline diff:
From e122fcdda1a96b79f10f44edd3c939c4d79a0ae3 Mon Sep 17 00:00:00 2001
From: Tobias Bussmann <t.bussmann@gmx.net>
Date: Thu, 4 Sep 2025 21:13:57 +0200
Subject: [PATCH] fix display of images in project news for apple mail and
 outlook

---
 templates/news/mail/pgproject.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/templates/news/mail/pgproject.html b/templates/news/mail/pgproject.html
index 55ddc2a0..c6c01006 100644
--- a/templates/news/mail/pgproject.html
+++ b/templates/news/mail/pgproject.html
@@ -4,8 +4,8 @@
 
 {%block content%}
 <div>
-  <img style="float: left" height="50" width="50" src="cid:slonik.png" alt="PostgreSQL logo">
-  <img style="float: right" height="50" width="50" src="cid:slonik.png" alt="PostgreSQL logo">
+  <img style="float: left; width: 50px" height="50" width="50" align="left" src="cid:slonik.png" alt="PostgreSQL logo">
+  <img style="float: right; width: 50px" height="50" width="50" align="right" src="cid:slonik.png" alt="PostgreSQL logo">
   <h1>{{news.title}}</h1>
 </div>
 {{news.content|markdown}}
-- 
2.50.1



  [application/pgp-signature] signature.asc (833B, 3-signature.asc)
  download

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-www@postgresql.org
  Cc: t.bussmann@gmx.net, jkatz@postgresql.org, pgsql-www@lists.postgresql.org
  Subject: Re: Images in news mails
  In-Reply-To: <4C210077-20E5-415C-8A69-B82331A42B9A@gmx.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox