Date: Wed, 18 Mar 2026 12:47:17 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	"Ing. Marijo Kristo" <marijo.kristo@icloud.com>,
	PostgreSQL Bug List <pgsql-bugs@lists.postgresql.org>
Subject: Re: Revoke Connect Privilege from Database not working
Message-ID: <abrlJRPovgwR6J0J@nathan>
References: 
 <CAKFQuwbB-ZKtN_p_y5sWa2MrTuy5=pRNPWSj1Ud4HHvTuhb54w@mail.gmail.com>
 <3467676.1744041977@sss.pgh.pa.us>
 <CAKFQuwbpC5w6sUq8gZQATrviZUT4bYpxW+=2uH6sWWMg7fWjzg@mail.gmail.com>
 <aRYLkTpazxKhnS_w@nathan>
 <1933586.1768950341@sss.pgh.pa.us>
 <aXDwtbXCu42Fdmrn@nathan>
 <2222571.1769014621@sss.pgh.pa.us>
 <aatOzgie9RlzbGoo@nathan>
 <abn22fc7-oHGObbZ@nathan>
 <770633.1773851777@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="a6GP3SbSyGuiJyTH"
Content-Disposition: inline
In-Reply-To: <770633.1773851777@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/abrlJRPovgwR6J0J%40nathan>
Precedence: bulk


--a6GP3SbSyGuiJyTH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Mar 18, 2026 at 12:36:17PM -0400, Tom Lane wrote:
> Thanks!  I was about to conclude that "silence means assent" and
> do that work, but you beat me to it.  Your changes look fine,
> except that where you have

Thanks for reviewing.

> +   ... A role can only attribute a grant
> +   to another role if they possess the privileges of that role.
> 
> the word "possess" seems a little ambiguous --- it's not clear whether
> it means SET or INHERIT privileges.  The grammar nerd in me doesn't
> like "they" either.  How about s/they possess/it inherits/ ?
> (likewise in revoke.sgml)

This crossed my mind when copy/pasting from the "GRANT on Roles" section,
but I obviously didn't do anything about it.  Fixed in the attached.

-- 
nathan

--a6GP3SbSyGuiJyTH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename=v4-0001-Allow-choosing-specific-grantors-via-GRANT-REVOKE.patch