public inbox for pgsql-performance@postgresql.org  

help / color / mirror / Atom feed

From: Richard Guo <guofenglinux@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Cándido Antonio Martínez Descalzo <candido@ninehq.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Potential partition pruning regression on PostgreSQL 18
Date: Thu, 9 Apr 2026 17:05:11 +0900
Message-ID: <CAMbWs4-gsKrhs9attotkw1eRNC3oFeB8damkO04_iukULWF=5g@mail.gmail.com> (raw)
In-Reply-To: <CAMbWs48w9424moGiS_f5jPhL3fMLRn+Q1FTLOzDsRZy-DvuUFA@mail.gmail.com>
References: <CAH5YaUwVUWETTyVECTnhs7C=CVwi+uMSQH=cOkwAUqMdvXdwWA@mail.gmail.com>
	<CAApHDvooK9iKSDWu45D3tjMBec2=6dXzKk_LzaGj_DqfTs6Xvw@mail.gmail.com>
	<CAMbWs49ittTvqB50_=eNPwN3-HAJX__s3kfn5nJc3nABTUZoyQ@mail.gmail.com>
	<CAMbWs48w9424moGiS_f5jPhL3fMLRn+Q1FTLOzDsRZy-DvuUFA@mail.gmail.com>

On Tue, Apr 7, 2026 at 5:00 PM Richard Guo <guofenglinux@gmail.com> wrote:
> Here are the more formal patches for HEAD and for v18.
>
> In the HEAD patch, I renamed strip_phvs_in_index_operand() to
> strip_noop_phvs() and moved it from indxpath.c to placeholder.c, since
> it is now a general-purpose utility used by both index matching and
> partition pruning code.
>
> However, since strip_phvs_in_index_operand() is an extern function
> declared in a public header, I'm worried that third-party extensions
> may have started calling it after it was introduced in ad66f705f.  So
> for the v18 back-patch, I retained strip_phvs_in_index_operand() in
> indxpath.c as a thin wrapper around the new strip_noop_phvs(), to
> avoid breaking such extensions in a minor release.
>
> Does this seem like reasonable caution, or is it overkill given how
> recently the function was introduced?

I prefer to be cautious, so I've committed the patches as-is.

- Richard

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-performance@postgresql.org
  Cc: guofenglinux@gmail.com, dgrowleyml@gmail.com, candido@ninehq.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Potential partition pruning regression on PostgreSQL 18
  In-Reply-To: <CAMbWs4-gsKrhs9attotkw1eRNC3oFeB8damkO04_iukULWF=5g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox