Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1RBp-0002kP-6s for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Jan 2021 09:51:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l1RBn-0001pK-9F for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Jan 2021 09:51:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1RBm-0001pD-Vc for pgsql-hackers@lists.postgresql.org; Mon, 18 Jan 2021 09:51:11 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l1RBg-0000Oo-LE for pgsql-hackers@lists.postgresql.org; Mon, 18 Jan 2021 09:51:10 +0000 Received: by mail-pj1-x102d.google.com with SMTP id x20so4048746pjh.3 for ; Mon, 18 Jan 2021 01:51:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NBcHJbRqxoJu8ppBG/+mIjNCkq+nzcaE1KAsEinYp1A=; b=i78HWSX8rIL5K7iib7K7Dxo8fdNVOTBSF8/VGMMziCTIyA3SrWxsu5RgqX5+a56kYh Gf6Vnxn1PrA5DatS9hvmf+1JHEsw1onzZiB9ZKs5cMK4iMJgniRrpTeMSDJDMreo22lG juypMtjS7/P/++PPbnFM3o+V57XO6oKOHmQDL3v5eeU9CsjQw4pUnbOVunwV+MjaArsn Xy3YSbMJDp3YdaRg2rrzPELe/WrFtkz0ELhBg/6XLEa8OUZGfUFd38jqTbUDech6L7nY +n6/02XNRvlmaBwanVtTN88ElZnhTd6BH0mhh0BMkw+yNfdxKIofD2oO31zL3sZI8++d 1gvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NBcHJbRqxoJu8ppBG/+mIjNCkq+nzcaE1KAsEinYp1A=; b=jqOl3mv4HMdfeTEgHBjRHzgmAeXSh6tCRdwGTtCwBHvDOOLLjHcjaBuF90feN1mWNm Ju2oTdO8pr2gzxvxi/xkfcqi4JWRsCl95OQr3YWrhLtdKTgWvgh2O97FfvpoCrCiSEOn Sp2aa8oMg1dnTdZPMufYK4EVcAptVGSbHt2lUtjjN++vZ4cfB1y/ARqQ/IQUCvH3NxJc E0efThzJl0nFxtep8HeIHvxQxvyzHn1tgNs7CkQLuSc2QDLhlvAe3q4fJ1f6TmIS4lvQ qLJPZSSS92nXCdrI92UyDvX1x+s2uqtttep9tLWx5xuw/MeaK3IzMLzh6PSDqyK45C49 YUYw== X-Gm-Message-State: AOAM531JMpCtp+B0M00dWI/Odj6TDOYqUQTNKyfiHxLmXMkt8PK5hUDT A1kN05STJY9DgIjBzW1iod5hSnGYiyqFc9+szPs= X-Google-Smtp-Source: ABdhPJxyYdS+W0Z+3qS/Zp/htvaGiFeHugT8d1JgL9ICicOQC8vcyR8RC9VhvGIxBQ087am5uKZtdOoMZjzCysxO1rc= X-Received: by 2002:a17:90a:e656:: with SMTP id ep22mr160966pjb.127.1610963462489; Mon, 18 Jan 2021 01:51:02 -0800 (PST) MIME-Version: 1.0 References: <20200924035637.GF28585@paquier.xyz> <20201001033824.GC8130@paquier.xyz> <51a9a68e8a998d04df17417d45c1dbd4@xs4all.nl> <89817942c99da01cd5e7850fe418436b@xs4all.nl> In-Reply-To: <89817942c99da01cd5e7850fe418436b@xs4all.nl> From: Pavel Stehule Date: Mon, 18 Jan 2021 10:50:25 +0100 Message-ID: Subject: Re: proposal: schema variables To: Erik Rijkers Cc: Michael Paquier , Zhihong Yu , Amit Kapila , DUVAL REMI , PostgreSQL Hackers Content-Type: multipart/alternative; boundary="000000000000ed877905b929a8be" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000ed877905b929a8be Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =C4=8Dt 14. 1. 2021 v 10:24 odes=C3=ADlatel Erik Rijkers nap= sal: > On 2021-01-14 07:35, Pavel Stehule wrote: > > [schema-variables-20210114.patch.gz] > > > Build is fine. My (small) list of tests run OK. > > I did notice a few more documentation peculiarities: > > > 'The PostgreSQL has schema variables' should be > 'PostgreSQL has schema variables' > > fixed > A link to the LET command should be added to the 'See Also' of the > CREATE VARIABLE, ALTER VARIABLE, and DROP VARIABLE pages. (After all, > the LET command is the most interesting) > Similarly, an ALTER VARIABLE link should be added to the 'See Also' > section of LET. > fixed > > Somehow, the sgml in the doc files causes too large spacing in the html, > example: > I copy from the LET html: > 'if that is defined. If no explicit' > (6 spaces between 'defined.' and 'If') > Can you have a look? Sorry - I can't find the cause. It occurs on a > few more places in the newly added sgml/html. The unwanted spaces are > visible also in the pdf. > Should be fixed in the last version. Probably there were some problems with invisible white chars. Thank you for check Pavel > (firefox 78.6.1, debian) > > > Thanks, > > Erik Rijkers > > > --000000000000ed877905b929a8be Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
=C4=8Dt 14. 1. 2021 v=C2=A010:24 odes= =C3=ADlatel Erik Rijkers <er@xs4all.nl> napsal:
O= n 2021-01-14 07:35, Pavel Stehule wrote:
> [schema-variables-20210114.patch.gz]


Build is fine. My (small) list of tests run OK.

I did notice a few more documentation peculiarities:


'The PostgreSQL has schema variables'=C2=A0 should be
'PostgreSQL has schema variables'



A link to the LET command should be added to the 'See Also' of the =
CREATE VARIABLE, ALTER VARIABLE, and DROP VARIABLE pages. (After all,
the LET command is the most interesting)
Similarly, an ALTER VARIABLE link should be added to the 'See Also'=
section of LET.

fixed



Somehow, the sgml in the doc files causes too large spacing in the html, example:
I copy from the LET html:
=C2=A0 =C2=A0 'if that is defined.=C2=A0 =C2=A0 =C2=A0 If no explicit&#= 39;
=C2=A0 =C2=A0 (6 spaces between 'defined.' and 'If')
Can you have a look?=C2=A0 Sorry - I can't find the cause.=C2=A0 It occ= urs on a
few more places in the newly added sgml/html.=C2=A0 The unwanted spaces are=
visible also in the pdf.

Should be fixe= d in the last version. Probably there were some problems with invisible whi= te chars.

Thank you for check

=
Pavel

=C2=A0
(firefox 78.6.1, debian)


Thanks,

Erik Rijkers


--000000000000ed877905b929a8be--