MIME-Version: 1.0
References: 
 <CAFj8pRCRUpNjX9Fb49SaADbRnCE69ndkOvtoeKxwvxetfJ8=kA@mail.gmail.com>
 <20180919112305.GA18604@zakirov.localdomain>
 <CAFj8pRCO+S9JVi+8L8MT7pcpz2+-orj5ju8k=e+PqZBhdYPhXg@mail.gmail.com>
 <CAFj8pRCB7ZDgTWD2BLaiATFEg_VpVgqTGkJwwd4t1hMTZ=4W=Q@mail.gmail.com>
 <CAFj8pRAc_=XEpS7csp0bozopsCwLc3z-C+_46RUYdPB7kxbNAw@mail.gmail.com>
 <CAFj8pRBSTLxQXcGXruo3zRDBdk378gA+nsi9FM9SxhV1qa0iCw@mail.gmail.com>
 <CAFj8pRAR03rRfAsbYpsP-NDq3npWZdiQoX9vkrX2HSuA9COuUg@mail.gmail.com>
 <CAFj8pRBrc6AULAT6e4cAbd86Y4qjTP9app=TsU15Hq=_2NNYfA@mail.gmail.com>
 <CAFj8pRAOB0UMA_FJy6dOHLSDEZDN6B9zV33LQFebSEgHQKBY4A@mail.gmail.com>
 <CAFj8pRCiGW4vF+RZrTC87-44_xf7zALZedQArA0=S7U_dh2qjw@mail.gmail.com>
 <CAFj8pRC9Xi=C4BXEXLMw_ba8AQZEs4a2ZGMOg6kpwMeo-wXrAg@mail.gmail.com>
 <CAFj8pRAG_u19iL98Pt7Qidqoq-mfKhof6gK4kOT_EBvqnHdrOg@mail.gmail.com>
 <CAFj8pRBQuKANoiQpUf5eSqummJ2v33UOePcaM7PTHCd9Szk1xg@mail.gmail.com>
 <b4791174-5a8a-f5ca-9641-2533c3424caf@pgmasters.net>
 <alpine.DEB.2.21.1903070853110.30581@lancre>
In-Reply-To: <alpine.DEB.2.21.1903070853110.30581@lancre>
From: Pavel Stehule <pavel.stehule@gmail.com>
Date: Thu, 7 Mar 2019 09:32:25 +0100
Message-ID: 
 <CAFj8pRAnq0X_8aw7dCO02JcYcwwYYuNDZGi9JpKKLcxVCH3D+Q@mail.gmail.com>
Subject: Re: Re: [HACKERS] proposal: schema variables
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: David Steele <david@pgmasters.net>,
 Artur Zakirov <a.zakirov@postgrespro.ru>,
	Dean Rasheed <dean.a.rasheed@gmail.com>,
 Gilles Darold <gilles.darold@dalibo.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Content-Type: multipart/alternative; boundary="0000000000005be8c705837cf436"
Precedence: bulk

--0000000000005be8c705837cf436
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

=C4=8Dt 7. 3. 2019 v 9:10 odes=C3=ADlatel Fabien COELHO <coelho@cri.ensmp.f=
r> napsal:

>
> Hello David,
>
> > This patch hasn't receive any review in a while and I'm not sure if
> that's
> > because nobody is interested or the reviewers think it does not need an=
y
> more
> > review.
> >
> > It seems to me that this patch as implemented does not quite satisfy an=
y
> one.
> >
> > I think we need to hear something from the reviewers soon or I'll push
> this
> > patch to PG13 as Andres recommends [1].
>
> I have discussed the feature extensively with Pavel on the initial thread=
.
>
> My strong opinion based on the underlying use case is that it that such
> session variables should be transactional by default, and Pavel strong
> opinion is that they should not, to be closer to Oracle comparable
> feature.
>
> According to the documentation, the current implementation does provide a
> transactional feature. However, it is not the default behavior, so I'm in
> disagreement on a key feature, although I do really appreciate that Pavel
> implemented the transactional behavior.
>
> Otherwise, ISTM that they could be named "SESSION VARIABLE" because the
> variable only exists in memory, in a session, and we could thing of addin=
g
> other kind of variables later on.
>
> I do intend to review it in depth when it is transactional by default.
>

I am sorry. I cannot to support this request. Variables are not
transactional. My opinion is strong in this part.

I would not to repeat this discussion from start. I am sorry.

Regards

Pavel


> Anyway, the patch is non trivial and very large, so targetting v12 now is
> indeed out of reach.
>
> --
> Fabien.
>
>

--0000000000005be8c705837cf436
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div id=3D":1p6" style=3D"display:none" c=
lass=3D"ajR" tabindex=3D"-1"><div id=3D":1e7" class=3D"uC"><img class=3D"aj=
T" src=3D"https://ssl.gstatic.com/ui/v1/icons/mail/images/cleardot.gif"></d=
iv></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gma=
il_attr">=C4=8Dt 7. 3. 2019 v=C2=A09:10 odes=C3=ADlatel Fabien COELHO &lt;<=
a href=3D"mailto:coelho@cri.ensmp.fr">coelho@cri.ensmp.fr</a>&gt; napsal:<b=
r></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex=
;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Hello David,<br>
<br>
&gt; This patch hasn&#39;t receive any review in a while and I&#39;m not su=
re if that&#39;s <br>
&gt; because nobody is interested or the reviewers think it does not need a=
ny more <br>
&gt; review.<br>
&gt;<br>
&gt; It seems to me that this patch as implemented does not quite satisfy a=
ny one.<br>
&gt;<br>
&gt; I think we need to hear something from the reviewers soon or I&#39;ll =
push this <br>
&gt; patch to PG13 as Andres recommends [1].<br>
<br>
I have discussed the feature extensively with Pavel on the initial thread.<=
br>
<br>
My strong opinion based on the underlying use case is that it that such <br=
>
session variables should be transactional by default, and Pavel strong <br>
opinion is that they should not, to be closer to Oracle comparable <br>
feature.<br>
<br>
According to the documentation, the current implementation does provide a <=
br>
transactional feature. However, it is not the default behavior, so I&#39;m =
in <br>
disagreement on a key feature, although I do really appreciate that Pavel<b=
r>
implemented the transactional behavior.<br>
<br>
Otherwise, ISTM that they could be named &quot;SESSION VARIABLE&quot; becau=
se the <br>
variable only exists in memory, in a session, and we could thing of adding =
<br>
other kind of variables later on.<br>
<br>
I do intend to review it in depth when it is transactional by default.<br><=
/blockquote><div><br></div><div>I am sorry. I cannot to support this reques=
t. Variables are not transactional. My opinion is strong in this part.<br><=
/div><div><br></div><div>I would not to repeat this discussion from start. =
I am sorry.<br></div><div><br></div><div>Regards</div><div><br></div><div>P=
avel<br></div><div><br></div><blockquote class=3D"gmail_quote" style=3D"mar=
gin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1=
ex">
<br>
Anyway, the patch is non trivial and very large, so targetting v12 now is <=
br>
indeed out of reach.<br>
<br>
-- <br>
Fabien.<br>
<br>
</blockquote></div></div>

--0000000000005be8c705837cf436--