public inbox for pgsql-performance@postgresql.org
help / color / mirror / Atom feedFrom: Pavel Stehule <pavel.stehule@gmail.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: David Steele <david@pgmasters.net>
Cc: Artur Zakirov <a.zakirov@postgrespro.ru>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Gilles Darold <gilles.darold@dalibo.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Subject: Re: Re: [HACKERS] proposal: schema variables
Date: Thu, 7 Mar 2019 09:32:25 +0100
Message-ID: <CAFj8pRAnq0X_8aw7dCO02JcYcwwYYuNDZGi9JpKKLcxVCH3D+Q@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1903070853110.30581@lancre>
References: <CAFj8pRCRUpNjX9Fb49SaADbRnCE69ndkOvtoeKxwvxetfJ8=kA@mail.gmail.com>
<20180919112305.GA18604@zakirov.localdomain>
<CAFj8pRCO+S9JVi+8L8MT7pcpz2+-orj5ju8k=e+PqZBhdYPhXg@mail.gmail.com>
<CAFj8pRCB7ZDgTWD2BLaiATFEg_VpVgqTGkJwwd4t1hMTZ=4W=Q@mail.gmail.com>
<CAFj8pRAc_=XEpS7csp0bozopsCwLc3z-C+_46RUYdPB7kxbNAw@mail.gmail.com>
<CAFj8pRBSTLxQXcGXruo3zRDBdk378gA+nsi9FM9SxhV1qa0iCw@mail.gmail.com>
<CAFj8pRAR03rRfAsbYpsP-NDq3npWZdiQoX9vkrX2HSuA9COuUg@mail.gmail.com>
<CAFj8pRBrc6AULAT6e4cAbd86Y4qjTP9app=TsU15Hq=_2NNYfA@mail.gmail.com>
<CAFj8pRAOB0UMA_FJy6dOHLSDEZDN6B9zV33LQFebSEgHQKBY4A@mail.gmail.com>
<CAFj8pRCiGW4vF+RZrTC87-44_xf7zALZedQArA0=S7U_dh2qjw@mail.gmail.com>
<CAFj8pRC9Xi=C4BXEXLMw_ba8AQZEs4a2ZGMOg6kpwMeo-wXrAg@mail.gmail.com>
<CAFj8pRAG_u19iL98Pt7Qidqoq-mfKhof6gK4kOT_EBvqnHdrOg@mail.gmail.com>
<CAFj8pRBQuKANoiQpUf5eSqummJ2v33UOePcaM7PTHCd9Szk1xg@mail.gmail.com>
<b4791174-5a8a-f5ca-9641-2533c3424caf@pgmasters.net>
<alpine.DEB.2.21.1903070853110.30581@lancre>
čt 7. 3. 2019 v 9:10 odesílatel Fabien COELHO <coelho@cri.ensmp.fr> napsal:
>
> Hello David,
>
> > This patch hasn't receive any review in a while and I'm not sure if
> that's
> > because nobody is interested or the reviewers think it does not need any
> more
> > review.
> >
> > It seems to me that this patch as implemented does not quite satisfy any
> one.
> >
> > I think we need to hear something from the reviewers soon or I'll push
> this
> > patch to PG13 as Andres recommends [1].
>
> I have discussed the feature extensively with Pavel on the initial thread.
>
> My strong opinion based on the underlying use case is that it that such
> session variables should be transactional by default, and Pavel strong
> opinion is that they should not, to be closer to Oracle comparable
> feature.
>
> According to the documentation, the current implementation does provide a
> transactional feature. However, it is not the default behavior, so I'm in
> disagreement on a key feature, although I do really appreciate that Pavel
> implemented the transactional behavior.
>
> Otherwise, ISTM that they could be named "SESSION VARIABLE" because the
> variable only exists in memory, in a session, and we could thing of adding
> other kind of variables later on.
>
> I do intend to review it in depth when it is transactional by default.
>
I am sorry. I cannot to support this request. Variables are not
transactional. My opinion is strong in this part.
I would not to repeat this discussion from start. I am sorry.
Regards
Pavel
> Anyway, the patch is non trivial and very large, so targetting v12 now is
> indeed out of reach.
>
> --
> Fabien.
>
>
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-performance@postgresql.org
Cc: pavel.stehule@gmail.com, coelho@cri.ensmp.fr, david@pgmasters.net, a.zakirov@postgrespro.ru, dean.a.rasheed@gmail.com, gilles.darold@dalibo.com, pgsql-hackers@lists.postgresql.org, peter.eisentraut@2ndquadrant.com
Subject: Re: Re: [HACKERS] proposal: schema variables
In-Reply-To: <CAFj8pRAnq0X_8aw7dCO02JcYcwwYYuNDZGi9JpKKLcxVCH3D+Q@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox