public inbox for pgsql-performance@postgresql.org  

help / color / mirror / Atom feed

From: Pavel Stehule <pavel.stehule@gmail.com>
To: Philippe BEAUDOIN <phb07@apra.asso.fr>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: proposal: schema variables
Date: Mon, 30 Dec 2019 21:05:40 +0100
Message-ID: <CAFj8pRA+SYbegM6f5OTamwhMdsVXB22mbmkscaErrhYge8ji3A@mail.gmail.com> (raw)
In-Reply-To: <157772317031.1198.14690129684698137065.pgcf@coridan.postgresql.org>
References: <CAFj8pRDY+m9OOxfO10R7J0PAkCCauM-TweaTrdsrsLGMb1VbEQ@mail.gmail.com>
	<CAFj8pRAcb+PLKJJOGn7POtcTuH8DaKqZNid-7UvB9_BtgshHEQ@mail.gmail.com>
	<157772317031.1198.14690129684698137065.pgcf@coridan.postgresql.org>

Hi

po 30. 12. 2019 v 17:27 odesílatel Philippe BEAUDOIN <phb07@apra.asso.fr>
napsal:

> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, passed
> Implements feature:       tested, passed
> Spec compliant:           not tested
> Documentation:            tested, failed
>
> Hi Pavel,
>
> I have tested the latest version of your patch.
> Both issues I reported are now fixed. And you largely applied my
> proposals. That's great !
>
> I have also spent some time to review more closely the documentation. I
> will send you a direct mail with an attached file for some minor comments
> on this topic.
>
> Except these documentation remarks to come, I haven't any other issue or
> suggestion to report.
> Note that I have not closely looked at the C code itself. But may be some
> other reviewers have already done that job.
> If yes, my feeling is that the patch could soon be set as "Ready for
> commiter".
>
> Best regards. Philippe.
>
> The new status of this patch is: Waiting on Author
>

Thank you very much for your comments, and notes. Updated patch attached.

Regards

Pavel


Attachments:

  [application/gzip] schema-variables-20191230.patch.gz (66.1K, 3-schema-variables-20191230.patch.gz)
  download

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-performance@postgresql.org
  Cc: pavel.stehule@gmail.com, phb07@apra.asso.fr, pgsql-hackers@lists.postgresql.org
  Subject: Re: proposal: schema variables
  In-Reply-To: <CAFj8pRA+SYbegM6f5OTamwhMdsVXB22mbmkscaErrhYge8ji3A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox