Feedback-ID: id4a34324:Fastmail
Date: Sun, 9 Feb 2025 12:59:27 -0500
From: Andres Freund <andres@anarazel.de>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: torikoshia <torikoshia@oss.nttdata.com>, pgsql-hackers@postgresql.org, 
	rjuju123@gmail.com, tgl@sss.pgh.pa.us, Bruce Momjian <bruce@momjian.us>
Subject: Re: RFC: Allow EXPLAIN to Output Page Fault Information
Message-ID: <myw76agwrlmisvamwbfl6ibxgwh5glzitydiwnfmtb5aui232i@274yxxtnbnsp>
References: <D6MJOHS7HZ80.3B17NDGUV6T47@jeltef.nl>
 <Z3LII9YEgp3kAZG-@momjian.us>
 <3861403.1735576764@sss.pgh.pa.us>
 <D6PENGW1PL79.266GQNPSMRIGA@jeltef.nl>
 <1f22794321b745549d54359d343e37b8@oss.nttdata.com>
 <D6V9GJ2LOLC5.1ZF3BWKKEBZWC@jeltef.nl>
 <CAM6-o=BE=oewSsdNKrbbNjR2muzQR49STXsuta+Wpq6CSyxTag@mail.gmail.com>
 <2c9d6eaf26df17bec13bb03bf1e9bcbb@oss.nttdata.com>
 <CAGECzQRvcLx44N3zd_DGCjY02XX4AqXX8mq4BiS8C9Froy+Jhg@mail.gmail.com>
 <CAGECzQQdc-k=M2fMCKa98kVZntc=6d3rpd6edt8Qs45cayfUeQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGECzQQdc-k=M2fMCKa98kVZntc=6d3rpd6edt8Qs45cayfUeQ@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/myw76agwrlmisvamwbfl6ibxgwh5glzitydiwnfmtb5aui232i%40274yxxtnbnsp>
Precedence: bulk

Hi,

On 2025-02-09 12:51:40 +0100, Jelte Fennema-Nio wrote:
> On Sat, 8 Feb 2025 at 14:54, Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
> > I'll play around with it a bit next week.
> 
> Okay, I played around with it and couldn't find any issues. I marked
> the patch as "ready for committer" in the commitfest app[1], given
> that all feedback in my previous email was very minor.

I'm somewhat against this patch, as it's fairly fundamentally incompatible
with AIO. There's no real way to get information in this manner if the IO
isn't executed synchronously in process context...

Greetings,

Andres