Message-ID: <de022aaa-057c-4f06-9b2b-10f45a11ac04@gmail.com>
Date: Fri, 22 May 2026 07:51:04 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Try a presorted outer path when referenced by an ORDER BY prefix
To: Zsolt Parragi <zsolt.parragi@percona.com>,
 pgsql-hackers@lists.postgresql.org
References: <19a9265c-c441-4a43-bc0d-dac533438da0@gmail.com>
 <67352ee9-fada-4253-a73d-d0f101dfb424@gmail.com>
 <CAN4CZFNXiuLztwqUCStR4VrCKH0WqHcsthP2CzkkFf5-k55=mA@mail.gmail.com>
Content-Language: en-US
From: Andrei Lepikhov <lepihov@gmail.com>
In-Reply-To: 
 <CAN4CZFNXiuLztwqUCStR4VrCKH0WqHcsthP2CzkkFf5-k55=mA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/de022aaa-057c-4f06-9b2b-10f45a11ac04%40gmail.com>
Precedence: bulk

On 13/05/2026 16:03, Zsolt Parragi wrote:
> +		else if (jointype == JOIN_RIGHT)
> +			ExecSetTupleBound(tuples_needed, innerPlanState(child_node));
> 
> Is this branch reachable? If I follow the code correctly, it can't
> happen with create_nestloop_path.

RIGHT NL seems like nonsense to me. This code stays here just to remind me to
add a check in the next version, if the community is interested.

> 
> pg_plan_advice also has test failures with the patch applied.

We already talked about this in the main thread for pg_plan_advice. Now, it is
unavoidable because pg_plan_advice limits optimisations that expand the planning
scope. Before, it was enough to use standard tools like create_seqscan_path and
add_path and provide a semantically correct plan. Now, every optimisation has to
meet pg_plan_advice's internal rules, which are much more restrictive.
I did not fix this test failure to highlight the unpleasant situation for
extension developers, but you can find the fix in the list [1].

[1]
https://www.postgresql.org/message-id/CAP53Pkw2Lw0bavkCR-ygmaGACBjwmY3Voq0Yhwo9rVOBWxQuyw@mail.gmail.com

-- 
regards, Andrei Lepikhov,
pgEdge