Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 21 May 2026 05:43:52 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Chao Li <li.evan.chao@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Michael Paquier <michael.paquier@gmail.com>,
	Xuneng Zhou <xunengzhou@gmail.com>
Subject: Re: Fix pg_stat_wal_receiver to show CONNECTING status
Message-ID: <ag4dCGAPBc5VFhCi@paquier.xyz>
References: <EF91FF76-1E2B-4F3B-9162-290B4DC517FF@gmail.com>
 <agxr29Hsz7FjxzlN@paquier.xyz>
 <1F153E64-B791-42FA-A60A-64813B20B81E@gmail.com>
 <ag00OeH1sbt5ie_6@paquier.xyz>
 <75CDE990-29D5-4D5C-BFE1-3840F19C0163@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="MGSW4+x6M619+Xlc"
Content-Disposition: inline
In-Reply-To: <75CDE990-29D5-4D5C-BFE1-3840F19C0163@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ag4dCGAPBc5VFhCi%40paquier.xyz>
Precedence: bulk


--MGSW4+x6M619+Xlc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 20, 2026 at 03:53:38PM +0800, Chao Li wrote:
> With v2, slot_name, sender_host, sender_port, and conninfo are
> already left NULL while the receiver is in CONNECTING state. I feel
> we don't have to show the timestamp fields either. Since the columns
> are named last_msg_send_time and last_msg_receipt_time, users may
> naturally interpret them as the last time a message was sent to or
> received from
> the primary. If we show the standby server start time in those
> columns, I am afraid that could be confusing.
>=20
> But I think it might be useful to show the *_lsn and *_tli values in
> CONNECTING state if they are available.

The original reason why ready_to_display has been introduced is this
one, where we wanted to have a strict control over the connection
information across multiple calls of pg_stat_get_wal_receiver():
https://www.postgresql.org/message-id/CAB7nPqQNbHQ7F7wDD_2qvGA_FUW-Leds9HQN=
M6kJnto7RFNhUg@mail.gmail.com

With v2, ready_to_display is still able to do the job it is defined
for.  This does not need to apply on the time fields, so IMO showing
them to the values they are initialized is not a big deal, and they
can actually be useful to know even in the early stage of connection
as they reveal the state of the code. =20

Note also that the time values could still show up based on their
initial values at the early connection stage, even after completing
walrcv_connect() and after ready_to_display is switched to true, so
it's not like these values are that confusing: we just expose them a
bit more at an earlier stage of the connection attempt process.  As a
whole v2 is fine, and addresses your issue.
--
Michael

--MGSW4+x6M619+Xlc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmoOHQgACgkQnvQgOdby
QH39/BAAgTBpvb5hMehRpFtFrjfuVy+4LBlfBwKj5asuQTVCpuLHrUfX5/lA0KO6
/9DMSbvEV87MP65A/JupINj3rMhMhg9nDTDP6AJfgAnDnaDzRnEAX4MA/k6fea26
Ws+Yoi0s8VLUMa2k8tdtzMILfsSbfiitNf9Jb8uFknQM6tQ+z0E4AIGHaNk29624
AjOFunY6ZNhVSCNbEpko4+kyYIbby0XPPMYu+E3F7jd41h5Mni0RNPsU8mL/sWdr
VMKDKF9JJWelxkW1xqDNp2ynw2cGQox5OzFpVYxqyNJkpvgzAneY6N1qXviLoDWU
hYm+8RTFjaw7zwmlN2o5PxadARyKdWY46NVmBKR5JzPzqp49QSfDmhDM5M21vAOx
Kbj5Qr81JCpYTYtMr9+DFMBku/ZdrWu5tE2vj9FKIrPCG0eioAHOfDBMJZzTX43+
u3GSYbXoELl0QLGmrcF0LWZ4pUKD5CFOBMM/bwkOotqVEIiQFdWdTwyyeKDSzNpy
s9hW5zfBVzmBKeKhRNeZkxNpgMgQqorHo/bzwybe+VO64Jdw3/9ZwcX7x/LeDHo0
SBMOsh0bzEEk6RR6s/5WfOzw76TxVl+R8S3dspuZDjU68QkFwGo/+6Ax1cPl1a4s
gTikeGvF0xFWAPVoEHB0mRncCfRAMY2mM4BNP2SuB0HrlyZbGGg=
=WOyz
-----END PGP SIGNATURE-----

--MGSW4+x6M619+Xlc--