Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 20 May 2026 13:10:33 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Chao Li <li.evan.chao@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Michael Paquier <michael.paquier@gmail.com>,
	Xuneng Zhou <xunengzhou@gmail.com>
Subject: Re: Fix pg_stat_wal_receiver to show CONNECTING status
Message-ID: <ag00OeH1sbt5ie_6@paquier.xyz>
References: <EF91FF76-1E2B-4F3B-9162-290B4DC517FF@gmail.com>
 <agxr29Hsz7FjxzlN@paquier.xyz>
 <1F153E64-B791-42FA-A60A-64813B20B81E@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="QFGWoSd0t18WFHVq"
Content-Disposition: inline
In-Reply-To: <1F153E64-B791-42FA-A60A-64813B20B81E@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ag00OeH1sbt5ie_6%40paquier.xyz>
Precedence: bulk


--QFGWoSd0t18WFHVq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 20, 2026 at 09:47:40AM +0800, Chao Li wrote:
> I just read v2, and it is actually the first solution I tried. The
> reason I gave up on that approach and switched to the implementation
> in v1 is that it may wrongly report last_msg_send_time,
> last_msg_receipt_time, and latest_end_time.

As of the code, we have the following at the top of WalReceiverMain()
before the first connection attempt:
    /* Initialise to a sanish value */
    now =3D GetCurrentTimestamp();
    walrcv->lastMsgSendTime =3D
       walrcv->lastMsgReceiptTime =3D walrcv->latestWalEndTime =3D now;

And the state of v2 is actually fine, because we finish by reporting
in the SQL calls values that represent the state the WAL receiver is=20
initialized at based on what the code does.  It would be IMO an issue
to hide this information, as they can offer hits about the moment when
we've begun a connection.
--
Michael

--QFGWoSd0t18WFHVq
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmoNNDkACgkQnvQgOdby
QH2xsg//QcOgqQhTNJMnZoOWR8A9gtzDnH8p1x1YD3Z6H9CAfA+H2fXr0ieKrssi
eOoJIU6F5hqGQJlOKouPoX1nQ+//eUjbJpj1LXZNVTDErylzESYAmYdl9phCYusD
iKSkDZ4ADB3KuU01eg52+TtJWUn/mqHE/HOeSmx2UGviRLQPciPZXpj9I8oFjpYC
xLFfXGs14pUoHPLk+JeFV+pr1zQ9Fy8YvricWpEO5rBkASdIvCOpaIaE4qfCHq/M
YAEhmcnp61asspFDjIHxCe4XtQUpRdZ0V4RUHB0We7C2IAaWU/b++XRdmL+uDqXM
jVes/Y0ruSkhzQcntxYuVLh+0LY8nzJRT5hnEGC1KqR86FI9to3rR86w8WPffKXb
dxW39+JZPzRzsUGx+N/V5NI0uy7m7pC/1EUg0d+LWCR58h0CaV87kfbxQCET53kw
wyPTEJ6j7lczSguyYpSOwm881cuWX28pvArnGH8AOeg30xWGBQ+CEDwFTRTErKo7
WKBNGioW6XonCBKqW9W/jzmcSLN41c7tNWTN8x7bbLwQGlxD/g2NbwYcq1MnhYli
a3jQTYR6rpbPtRDc+pNf493ru4pKGrery6zWysav4k4tvnPLQIW797+i4ZqC/hPk
XaYXPrprr5/24DyspttHZVYdfiKPLN+FyZwaZX95RB2pkqU/tRg=
=PM8V
-----END PGP SIGNATURE-----

--QFGWoSd0t18WFHVq--