MIME-Version: 1.0
References: 
 <CANxoLDdJsRJqnjMXV3yjsk07Z5iRWxG-c2hZJC7bAKqf8ZXj_A@mail.gmail.com>
 <CAPXBC8+i=c7FCcGr6OR0y=mcx3EfdXuxyk_XYgSQ7+egGvb8vA@mail.gmail.com>
 <CANxoLDdef6wW=T5czPSKPsk3xWeEHTeKxxxYMucmr-HURyoOgQ@mail.gmail.com>
In-Reply-To: 
 <CANxoLDdef6wW=T5czPSKPsk3xWeEHTeKxxxYMucmr-HURyoOgQ@mail.gmail.com>
From: Philip Alger <paalger0@gmail.com>
Date: Thu, 16 Oct 2025 07:36:05 -0500
Message-ID: 
 <CAPXBC8J-ZBqaUh7ZcC-SBzTiOZG8P7ssUx6eLKYzVNkzKajpzQ@mail.gmail.com>
Subject: Re: [PATCH] Add pg_get_policy_ddl() function to reconstruct CREATE
 POLICY statement
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000013efa4064145dd6b"
Archived-At: 
 <https://www.postgresql.org/message-id/CAPXBC8J-ZBqaUh7ZcC-SBzTiOZG8P7ssUx6eLKYzVNkzKajpzQ%40mail.gmail.com>
Precedence: bulk

--00000000000013efa4064145dd6b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Akshay,


>>> As for the statement terminator, it=E2=80=99s useful to include it, whi=
le
>> running multiple queries together could result in a syntax error. In my
>> opinion, there=E2=80=99s no harm in providing the statement terminator.
>>
> However, I=E2=80=99ve modified the logic to add the statement terminator =
at the
> end instead of appending to a new line.
>
>>
>>
Regarding putting the terminator at the end, I think my original comment
got cut off by my poor editing. Yes, that's what I was referring to; no
need to append it to a new line.

--=20
Best, Phil Alger

--00000000000013efa4064145dd6b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Akshay,</div><div dir=3D"ltr"><br></di=
v><div class=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2=
04,204);padding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_quote"><bloc=
kquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:=
1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div class=3D=
"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px=
 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D=
"ltr"><br></div>
</blockquote></div><div>As for the statement terminator, it=E2=80=99s usefu=
l to include it, while running multiple queries together could result in a =
syntax error. In my opinion, there=E2=80=99s no harm in providing the state=
ment terminator.</div></div></blockquote><div>However, I=E2=80=99ve modifie=
d the logic to add the statement terminator at the end instead of appending=
 to a new line.=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margi=
n:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex=
"><div dir=3D"ltr"><br></div></blockquote></div></div></blockquote></div><d=
iv><br></div><div>Regarding putting the terminator at the end, I think my o=
riginal comment got cut off by my poor editing. Yes, that&#39;s what I was =
referring to; no need to append it to a new line.=C2=A0</div><div><br></div=
><span class=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" clas=
s=3D"gmail_signature"><div dir=3D"ltr">Best, Phil Alger</div></div></div>

--00000000000013efa4064145dd6b--