MIME-Version: 1.0
References: 
 <CANxoLDdJsRJqnjMXV3yjsk07Z5iRWxG-c2hZJC7bAKqf8ZXj_A@mail.gmail.com>
 <202510151529.s3fpwsgben57@alvherre.pgsql>
In-Reply-To: <202510151529.s3fpwsgben57@alvherre.pgsql>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Thu, 16 Oct 2025 13:47:53 +0530
Message-ID: 
 <CANxoLDfXKWRQ0KZFtaChr2NX3UWSQq3ji7OJqBp-_-th2Zj6Fg@mail.gmail.com>
Subject: Re: [PATCH] Add pg_get_policy_ddl() function to reconstruct CREATE
 POLICY statement
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000a2e2830641424187"
Archived-At: 
 <https://www.postgresql.org/message-id/CANxoLDfXKWRQ0KZFtaChr2NX3UWSQq3ji7OJqBp-_-th2Zj6Fg%40mail.gmail.com>
Precedence: bulk

--000000000000a2e2830641424187
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 15, 2025 at 10:55=E2=80=AFPM =C3=81lvaro Herrera <alvherre@kuri=
lemu.de>
wrote:

> Hello,
>
> I have reviewed this patch before and provided a number of comments that
> have been addressed by Akshay (so I encourage you to list my name and
> this address in a Reviewed-by trailer line in the commit message).  One
> thing I had not noticed is that while this function has a "pretty" flag,
> it doesn't use it to pass anything to pg_get_expr_worker()'s prettyFlags
> argument, and I think it should -- probably just
>
>   prettyFlags =3D GET_PRETTY_FLAGS(pretty);
>
> same as pg_get_querydef() does.
>

   Fixed and added 'Reviewed-by:'

>
> Thanks
>
> --
> =C3=81lvaro Herrera         PostgreSQL Developer  =E2=80=94
> https://www.EnterpriseDB.com/
>

--000000000000a2e2830641424187
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Oct 15,=
 2025 at 10:55=E2=80=AFPM =C3=81lvaro Herrera &lt;<a href=3D"mailto:alvherr=
e@kurilemu.de">alvherre@kurilemu.de</a>&gt; wrote:<br></div><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex">Hello,<br>
<br>
I have reviewed this patch before and provided a number of comments that<br=
>
have been addressed by Akshay (so I encourage you to list my name and<br>
this address in a Reviewed-by trailer line in the commit message).=C2=A0 On=
e<br>
thing I had not noticed is that while this function has a &quot;pretty&quot=
; flag,<br>
it doesn&#39;t use it to pass anything to pg_get_expr_worker()&#39;s pretty=
Flags<br>
argument, and I think it should -- probably just <br>
<br>
=C2=A0 prettyFlags =3D GET_PRETTY_FLAGS(pretty);<br>
<br>
same as pg_get_querydef() does.<br></blockquote><div><br>=C2=A0 =C2=A0Fixed=
 and added &#39;Reviewed-by:&#39;=C2=A0 =C2=A0</div><blockquote class=3D"gm=
ail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,=
204,204);padding-left:1ex">
<br>
Thanks<br>
<br>
-- <br>
=C3=81lvaro Herrera=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0PostgreSQL Developer=
=C2=A0 =E2=80=94=C2=A0 <a href=3D"https://www.EnterpriseDB.com/" rel=3D"nor=
eferrer" target=3D"_blank">https://www.EnterpriseDB.com/</a><br>
</blockquote></div></div>

--000000000000a2e2830641424187--