MIME-Version: 1.0
References: <20230828115252.c1b018605b9a0756a30c3382@sraoss.co.jp>
 <20230828160530.adde1e20f257d7d345989163@sraoss.co.jp> <CACJufxEoCCJE1vntJp1SWjen8vBUa3vZLgL=swPwar4zim976g@mail.gmail.com>
 <20230902.204634.955758704959569058.t-ishii@sranhm.sra.co.jp>
 <CACJufxFjankFQDNppOfqCTpY=zW4Q0+2WCmKjT95kggiT978Lw@mail.gmail.com>
 <CAHut+PsDpBTxZ7bLhko7_E-C7khMhoNJcriNQ_p_gWjADn01vg@mail.gmail.com>
 <20240123162327.c2803162619dd7634cca0b6c@sraoss.co.jp> <20240304115846.2275fb44fd904e8789d43590@sraoss.co.jp>
 <20240329234700.73ff2e28c9248d29f8fa6a66@sraoss.co.jp> <20240331225931.712683cecb26862b73b2b822@sraoss.co.jp>
 <20240702170311.1ddb417759a48ff12c555b92@sranhm.sraoss.co.jp.sranhm> <20240711132357.fe3f78c184cfa99159208178@sranhm.sraoss.co.jp>
In-Reply-To: <20240711132357.fe3f78c184cfa99159208178@sranhm.sraoss.co.jp>
From: Kirill Reshke <reshkekirill@gmail.com>
Date: Tue, 6 Aug 2024 19:29:09 +0500
Message-ID: <CALdSSPiQbTmLRjj3TbzEaioqJ2ubkAtRbGn=OtXhT-EAHJvXXw@mail.gmail.com>
Subject: Re: Incremental View Maintenance, take 2
To: Yugo NAGATA <nagata@sraoss.co.jp>
Cc: Peter Smith <smithpb2250@gmail.com>, jian he <jian.universality@gmail.com>, 
	Tatsuo Ishii <ishii@sraoss.co.jp>, pgsql-hackers@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CALdSSPiQbTmLRjj3TbzEaioqJ2ubkAtRbGn%3DOtXhT-EAHJvXXw%40mail.gmail.com>
Precedence: bulk

On Thu, 11 Jul 2024 at 09:24, Yugo NAGATA <nagata@sraoss.co.jp> wrote:
>
> On Tue, 2 Jul 2024 17:03:11 +0900
> Yugo NAGATA <nagata@sraoss.co.jp> wrote:
>
> > On Sun, 31 Mar 2024 22:59:31 +0900
> > Yugo NAGATA <nagata@sraoss.co.jp> wrote:
> > > >
> > > > Also, I added a comment on RelationIsIVM() macro persuggestion from jian he.
> > > > In addition, I fixed a failure reported from cfbot on FreeBSD build caused by;
> > > >
> > > >  WARNING:  outfuncs/readfuncs failed to produce an equal rewritten parse tree
> > > >
> > > > This warning was raised since I missed to modify outfuncs.c for a new field.
> > >
> > > I found cfbot on FreeBSD still reported a failure due to
> > > ENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS because the regression test used
> > > wrong role names. Attached is a fixed version, v32.
> >
> > Attached is a rebased version, v33.
>
> I updated the patch to bump up the version numbers in psql and pg_dump codes
> from 17 to 18.
>
> Regards,
> Yugo Nagata
>
> >
> > Regards,
> > Yugo Nagata
> >
> >
> > --
> > Yugo NAGATA <nagata@sraoss.co.jp>
>
>
> --
> Yugo NAGATA <nagata@sraoss.co.jp>

Small updates with something o found recent days:

```
db2=# create incremental materialized view v2 as select * from v1;
ERROR:  VIEW or MATERIALIZED VIEW is not supported on incrementally
maintainable materialized view
```
Error messaging is not true, create view v2 as select * from v1; works fine.


```
db2=# create incremental materialized view vv2 as select i,j2, i / j2
from t1 join t2 on true;
db2=# insert into t2 values(1,0);
ERROR:  division by zero
```
It is very strange to receive `division by zero` while inserting into
relation, isn't it? Can we add some hints/CONTEXT here?
Regular triggers do it:
```
db2=# insert into ttt values(100000,0);
ERROR:  division by zero
CONTEXT:  PL/pgSQL function f1() line 3 at IF
```


-- 
Best regards,
Kirill Reshke