MIME-Version: 1.0
References: <D6PENGW1PL79.266GQNPSMRIGA@jeltef.nl> <1f22794321b745549d54359d343e37b8@oss.nttdata.com>
 <D6V9GJ2LOLC5.1ZF3BWKKEBZWC@jeltef.nl> <CAM6-o=BE=oewSsdNKrbbNjR2muzQR49STXsuta+Wpq6CSyxTag@mail.gmail.com>
 <2c9d6eaf26df17bec13bb03bf1e9bcbb@oss.nttdata.com> <CAGECzQRvcLx44N3zd_DGCjY02XX4AqXX8mq4BiS8C9Froy+Jhg@mail.gmail.com>
 <CAGECzQQdc-k=M2fMCKa98kVZntc=6d3rpd6edt8Qs45cayfUeQ@mail.gmail.com>
 <myw76agwrlmisvamwbfl6ibxgwh5glzitydiwnfmtb5aui232i@274yxxtnbnsp>
 <2035079.1739124342@sss.pgh.pa.us> <CAGECzQTm6oEEY4yO_FO0ZBtUuJX+pYiXhw2GPPRMzq_5DP5_fQ@mail.gmail.com>
 <edvo7bpgi7rcthj7btsduleep4j6dcnsx3a2aqrwmybetttmkw@g5chr66cckg6>
In-Reply-To: <edvo7bpgi7rcthj7btsduleep4j6dcnsx3a2aqrwmybetttmkw@g5chr66cckg6>
From: Jelte Fennema-Nio <postgres@jeltef.nl>
Date: Mon, 10 Feb 2025 23:52:17 +0100
Message-ID: <CAGECzQTydZ33miLd=KdbfrV17RowRGBwQrS28hZ0i6+YhetYgg@mail.gmail.com>
Subject: Re: RFC: Allow EXPLAIN to Output Page Fault Information
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, torikoshia <torikoshia@oss.nttdata.com>, 
	pgsql-hackers@postgresql.org, rjuju123@gmail.com, 
	Bruce Momjian <bruce@momjian.us>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAGECzQTydZ33miLd%3DKdbfrV17RowRGBwQrS28hZ0i6%2BYhetYgg%40mail.gmail.com>
Precedence: bulk

On Mon, 10 Feb 2025 at 14:31, Andres Freund <andres@anarazel.de> wrote:
> I think it'll always be a subset of use. It doesn't make sense to use DIO for
> a small databases or untuned databases. Or a system that's deliberately
> overcommmitted.

Thanks, that's useful context.

> But this will also not work with AIO w/ Buffered IO. Which we hope to use much
> more commonly.

To be clear, here you mean worker based AIO right? Because it would
work with io_uring based AIO, right?

> If suddenly I have to reimplement something like this to work with worker
> based IO, it'll certainly take longer to get to AIO.

I totally understand. But in my opinion it would be completely fine to
decide that these new IO stats are simply not available for worker
based IO. Just like they're not available for Windows either with this
patch.

I think it would be a shame to make perfect be the enemy of good here
(as often seems to happen with PG patches). I'd rather have this
feature for some setups, than for no setups at all.