public inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Xuneng Zhou <xunengzhou@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Michael Paquier <michael.paquier@gmail.com>
Subject: Re: Fix pg_stat_wal_receiver to show CONNECTING status
Date: Sat, 23 May 2026 20:51:40 -0700
Message-ID: <CABPTF7VSX4b29unitKHN-dtiTy6hx3nvLsirUBNA=opOhnv+Mg@mail.gmail.com> (raw)
In-Reply-To: <CABPTF7UTJ0tyHUaYrPyYet6n_p1=GfUDYjQ-1LbXRa_4h=rP9g@mail.gmail.com>
References: <agxr29Hsz7FjxzlN@paquier.xyz>
<1F153E64-B791-42FA-A60A-64813B20B81E@gmail.com>
<ag00OeH1sbt5ie_6@paquier.xyz>
<75CDE990-29D5-4D5C-BFE1-3840F19C0163@gmail.com>
<ag4dCGAPBc5VFhCi@paquier.xyz>
<1B695040-F544-447C-A6A8-C8BFF7F799D1@gmail.com>
<E2A0E5FB-E841-4D4B-96F8-B4016359CDF0@gmail.com>
<ag711gjcxuaBqpp8@paquier.xyz>
<1B9D2BAF-C73A-4A79-852C-17FB2A474AC0@gmail.com>
<93526C6D-DE0A-4B7D-B908-366735FC211D@gmail.com>
<ahDlVH-EjhIAL9OX@paquier.xyz>
<B18D0AF0-F9ED-4579-8FFF-AAF13872B465@gmail.com>
<CABPTF7UTJ0tyHUaYrPyYet6n_p1=GfUDYjQ-1LbXRa_4h=rP9g@mail.gmail.com>
On Sat, May 23, 2026 at 8:51 AM Xuneng Zhou <xunengzhou@gmail.com> wrote:
>
> On Fri, May 22, 2026 at 4:56 PM Chao Li <li.evan.chao@gmail.com> wrote:
> >
> >
> >
> > > On May 23, 2026, at 07:23, Michael Paquier <michael@paquier.xyz> wrote:
> > >
> > > On Fri, May 22, 2026 at 10:06:33AM +0800, Chao Li wrote:
> > >> Here comes the patch set:
> > >>
> > >> * v3-0001 is the exactly same as v2-0001
> > >> * In v3-0002, the change in walreceiverfuncs.c is the same as the
> > >> * previous diff, and I tuned the test change a little bit.
> > >
> > > Okay, applied the first one on HEAD, and backpatched the second one.
> > > --
> > > Michael
> >
> > Thank you very much for applying the patch and still working hard during the PGConf.
> >
>
>
> Thanks for dealing with this and sorry for being late in the game.
> I'll do a post-commit review while I'm on the flight.
I agree with Michael's point that displaying partial columns gated by
the flag ready-to-display is not very ideal. Showing two columns in
connecting status inconsistently in some scenarios implies something
broken under the hood.[1] It may require extra documentation effort to
dispel the confusion for the user.
As for the timeline/lsn and timestamp values, they may still be useful
operationally because they reveal when the WAL receiver entered this
part of the code. Although they are not meant to be used and
interpreted in this way... So there's some risk for misinterpretation,
but they precedes the changes.
[1] https://www.postgresql.org/message-id/aaj_WA1Du4micf9t@paquier.xyz
--
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: xunengzhou@gmail.com, li.evan.chao@gmail.com, michael@paquier.xyz, michael.paquier@gmail.com
Subject: Re: Fix pg_stat_wal_receiver to show CONNECTING status
In-Reply-To: <CABPTF7VSX4b29unitKHN-dtiTy6hx3nvLsirUBNA=opOhnv+Mg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox