MIME-Version: 1.0
From: Imran Zaheer <imran.zhir@gmail.com>
Date: Thu, 21 May 2026 21:32:36 +0500
Message-ID: 
 <CA+UBfaktds57dw2M8BEv_kS-=ixph3w+3MxKixtaDQMi_k7Ybg@mail.gmail.com>
Subject: effective_wal_level is not decreasing after using REPACK
 (CONCURRENTLY)
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000744e950652567691"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BUBfaktds57dw2M8BEv_kS-%3Dixph3w%2B3MxKixtaDQMi_k7Ybg%40mail.gmail.com>
Precedence: bulk

--000000000000744e950652567691
Content-Type: text/plain; charset="UTF-8"

Hi

The recent support for dynamic toggling of logical decoding (67c2097)
disables logical
decoding if no logical slots are present. But the repack command doesn't seem to
coordinate with this toggling. The effective_wal_level is not
decreasing after using repack concurrently.

postgres=# show effective_wal_level;
 effective_wal_level
---------------------
 replica
(1 row)

postgres=# create table foo(a int primary key);
CREATE TABLE
postgres=# REPACK (CONCURRENTLY) foo;
2026-05-21 20:46:25.423 PKT [1591896] LOG:  logical decoding is
enabled upon creating a new logical replication slot
2026-05-21 20:46:25.634 PKT [1591896] LOG:  logical decoding found
consistent point at 0/018F36D0
2026-05-21 20:46:25.634 PKT [1591896] DETAIL:  There are no running
transactions.
REPACK
postgres=# select slot_name from pg_replication_slots;
 slot_name
-----------
(0 rows)

postgres=# show effective_wal_level;
 effective_wal_level
---------------------
 logical
(1 row)


The server has to be restarted in order to decrease the
effective_wal_level. REPACK CONCURRENTLY uses a temporary slot that is
dropped at the time of cleanup,  but logical decoding is not disabled.

This may be related to both commits, 28d534e and 67c2097

The attached patch adds the `RequestDisableLogicalDecoding` call to
`repack_cleanup_logical_decoding` after the replication slot is
dropped so the checkpointer will take care of it..


Thanks
Imran Zaheer

--000000000000744e950652567691
Content-Type: text/x-patch; charset="US-ASCII";
	name="v1-0001-Disable-logical-decoding-after-REPACK-CONCURRENTL.patch"
Content-Disposition: attachment;
	filename="v1-0001-Disable-logical-decoding-after-REPACK-CONCURRENTL.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mpfpkyba0>
X-Attachment-Id: f_mpfpkyba0

RnJvbSA4YTEyNGFhYWUzMTYxMmExOWNiMzg0MzRlODYxMjE2MmI2YWU3NmZmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBJbXJhbiBaYWhlZXIgPGltcmFuLnpoaXJAZ21haWwuY29tPgpE
YXRlOiBUaHUsIDIxIE1heSAyMDI2IDIwOjU1OjExICswNTAwClN1YmplY3Q6IFtQQVRDSCB2MV0g
RGlzYWJsZSBsb2dpY2FsIGRlY29kaW5nIGFmdGVyIFJFUEFDSyAoQ09OQ1VSUkVOVExZKQoKZWZm
ZWN0aXZlIFdBTCBsZXZlbCBzaG91bGQgYmUgZGVjcmVhc2VkIGFmdGVyIGBSRVBBQ0sgKENPTkNV
UlJFTlRMWSlgCmlmIG5lY2Vzc2FyeS4gUmVxdWVzdCB0byBkaXNhYmxlIGxvZ2ljYWwgZGVjb2Rp
bmcgYXV0b21hdGljYWxseQpkdXJpbmcgcmVwYWNrIGNsZWFudXAuCi0tLQogc3JjL2JhY2tlbmQv
Y29tbWFuZHMvcmVwYWNrX3dvcmtlci5jICAgICAgICAgICB8ICAzICsrKwogc3JjL3Rlc3QvcmVj
b3ZlcnkvdC8wNTFfZWZmZWN0aXZlX3dhbF9sZXZlbC5wbCB8IDE0ICsrKysrKysrKysrKysrCiAy
IGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9zcmMvYmFja2Vu
ZC9jb21tYW5kcy9yZXBhY2tfd29ya2VyLmMgYi9zcmMvYmFja2VuZC9jb21tYW5kcy9yZXBhY2tf
d29ya2VyLmMKaW5kZXggYjg0MDQxMzcyYjguLjI3NmY1ZDRmZDlhIDEwMDY0NAotLS0gYS9zcmMv
YmFja2VuZC9jb21tYW5kcy9yZXBhY2tfd29ya2VyLmMKKysrIGIvc3JjL2JhY2tlbmQvY29tbWFu
ZHMvcmVwYWNrX3dvcmtlci5jCkBAIC0zMjQsNiArMzI0LDkgQEAgcmVwYWNrX2NsZWFudXBfbG9n
aWNhbF9kZWNvZGluZyhMb2dpY2FsRGVjb2RpbmdDb250ZXh0ICpjdHgpCiAKIAlGcmVlRGVjb2Rp
bmdDb250ZXh0KGN0eCk7CiAJUmVwbGljYXRpb25TbG90RHJvcEFjcXVpcmVkKCk7CisKKwkvKiBD
aGVja3BvaW50ZXIgd2lsbCBkaXNhYmxlIHRoZSBkZWNvZGluZyBpZiBuZWNlc3NhcnkgKi8KKwlS
ZXF1ZXN0RGlzYWJsZUxvZ2ljYWxEZWNvZGluZygpOwogfQogCiAvKgpkaWZmIC0tZ2l0IGEvc3Jj
L3Rlc3QvcmVjb3ZlcnkvdC8wNTFfZWZmZWN0aXZlX3dhbF9sZXZlbC5wbCBiL3NyYy90ZXN0L3Jl
Y292ZXJ5L3QvMDUxX2VmZmVjdGl2ZV93YWxfbGV2ZWwucGwKaW5kZXggYzRjMjY2MmY3MmIuLjY2
M2VkNzMwYzkxIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWNvdmVyeS90LzA1MV9lZmZlY3RpdmVf
d2FsX2xldmVsLnBsCisrKyBiL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDUxX2VmZmVjdGl2ZV93YWxf
bGV2ZWwucGwKQEAgLTE0MSw2ICsxNDEsMjAgQEAgdGVzdF93YWxfbGV2ZWwoJHByaW1hcnksICJy
ZXBsaWNhfHJlcGxpY2EiLAogCSJlZmZlY3RpdmVfd2FsX2xldmVsIGdvdCBkZWNyZWFzZWQgdG8g
J3JlcGxpY2EnIGFmdGVyIGludmFsaWRhdGluZyB0aGUgbGFzdCBsb2dpY2FsIHNsb3QiCiApOwog
CisjIExvZ2ljYWwgZGVjb2Rpbmcgc2hvdWxkIGJlIGRpc2FibGVkIGFmdGVyIHJlcGFja2luZwor
JHByaW1hcnktPnNhZmVfcHNxbCgncG9zdGdyZXMnLCBxcVtjcmVhdGUgdGFibGUgZm9vKGEgaW50
IHByaW1hcnkga2V5KV0pOworJHByaW1hcnktPnNhZmVfcHNxbCgncG9zdGdyZXMnLCBxcVtyZXBh
Y2sgKGNvbmN1cnJlbnRseSkgZm9vO10pOworb2soICRwcmltYXJ5LT5sb2dfY29udGFpbnMoCisJ
CSJsb2dpY2FsIGRlY29kaW5nIGlzIGVuYWJsZWQgdXBvbiBjcmVhdGluZyBhIG5ldyBsb2dpY2Fs
IHJlcGxpY2F0aW9uIHNsb3QiCisJKSwKKwkibG9naWNhbCBkZWNvZGluZyBoYXMgYmVlbiBlbmFi
bGVkIHVwb24gY3JlYXRpbmcgYSB0ZW1wIHNsb3QiKTsKKworIyBXYWl0IGZvciB0aGUgY2hlY2tw
b2ludGVyIHRvIGRpc2FibGUgbG9naWNhbCBkZWNvZGluZy4KK3dhaXRfZm9yX2xvZ2ljYWxfZGVj
b2RpbmdfZGlzYWJsZWQoJHByaW1hcnkpOwordGVzdF93YWxfbGV2ZWwoJHByaW1hcnksICJyZXBs
aWNhfHJlcGxpY2EiLAorCSJlZmZlY3RpdmVfd2FsX2xldmVsIGdvdCBkZWNyZWFzZWQgdG8gJ3Jl
cGxpY2EnIGFmdGVyIHRoZSBSRVBBQ0sgKENPTkNVUlJFTlRMWSkgY29tbWFuZCIKKyk7CisKICMg
UmV2ZXJ0IHRoZSBtb2RpZmllZCBzZXR0aW5ncywgYW5kIHJlc3RhcnQgdGhlIHNlcnZlci4KICRw
cmltYXJ5LT5hZGp1c3RfY29uZigncG9zdGdyZXNxbC5jb25mJywgJ21heF9zbG90X3dhbF9rZWVw
X3NpemUnLCB1bmRlZik7CiAkcHJpbWFyeS0+YWRqdXN0X2NvbmYoJ3Bvc3RncmVzcWwuY29uZics
ICdtaW5fd2FsX3NpemUnLCB1bmRlZik7Ci0tIAoyLjM0LjEKCg==
--000000000000744e950652567691--