Message-ID: <87c8f8ac-614b-4679-afc7-f591b76c8ff7@gmail.com>
Date: Fri, 22 May 2026 12:40:28 -0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Avoid leaking system path from pg_available_extensions
To: Jim Jones <jim.jones@uni-muenster.de>, Chao Li <li.evan.chao@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Andrew Dunstan <andrew@dunslane.net>
References: <357C774A-ECE9-4455-B641-315205D4D9A1@gmail.com>
 <96203151-6929-4d88-85a0-d552ee258a24@gmail.com>
 <cf40d36e-e45a-41c2-aea1-7834bcb62da9@uni-muenster.de>
Content-Language: en-US
From: Matheus Alcantara <matheusssilv97@gmail.com>
In-Reply-To: <cf40d36e-e45a-41c2-aea1-7834bcb62da9@uni-muenster.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/87c8f8ac-614b-4679-afc7-f591b76c8ff7%40gmail.com>
Precedence: bulk

On 22/05/26 04:25, Jim Jones wrote:
> On 21/05/2026 17:12, Matheus Alcantara wrote:
>> I've reproduced the issue and the fix looks correct to me.
> 
> same here, +1
> 

Thank you for also testing.

> I was wondering if creating a constant for it would be, stylistically
> speaking, a cleaner solution. For instance:
> 
> #define EXTENSION_SYSTEM_MACRO  "$system"
> 
> I realize that it's used only inside get_extension_control_directories()
> but since it is even mentioned in the docs, I guess it wouldn't be a bad
> idea.
> 

I'm not against it but I don't think that it's necessary since as you 
mention, only get_extension_control_directories() use.

--
Matheus Alcantara
EDB: https://www.enterprisedb.com