Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v95G0-009hvG-6m for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Oct 2025 17:25:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v95Fy-007QD9-L9 for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Oct 2025 17:25:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v95Fx-007QD1-T2 for pgsql-hackers@lists.postgresql.org; Wed, 15 Oct 2025 17:25:45 +0000 Received: from fout-a6-smtp.messagingengine.com ([103.168.172.149]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v95Ft-002Mdv-1w for pgsql-hackers@postgresql.org; Wed, 15 Oct 2025 17:25:44 +0000 Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfout.phl.internal (Postfix) with ESMTP id 58AC8EC0191; Wed, 15 Oct 2025 13:25:39 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Wed, 15 Oct 2025 13:25:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm1; t=1760549139; x= 1760635539; bh=0/eMc4c5Ol9ee4bJ9dnyfdMjbncOkbk8BlSP7Zc7E8A=; b=H plfns8i5F3AUqsE1GFU8UYWtr+zjWGXHUIusdwQwMVkVXD0Ri3NcUEbEGFEznfh6 Rt4nshYWSDXyPbNyVzooBBZIPDS56QM4zlnMYOnyJQ+lzacCBxQIr+Bkb6l2WQpM 8HckV2wubxd60yPlPPIgx0cQyOU4p2fCjEuRITGzAoyRaIpvRZo4dqqiFESYIW0v q8O9XEvVR9eilYT4rcqyAmTvdGH/0aYP2tODbUQBWwAsi/gBDdsLyBZmv+y1GaYa z0Sn5J/G1Ng+76DpGxYKlwt5aH/X36OlVdy+KSAmwfo9lDfO+iRwY3B5/MTJsC12 enkAvjEhupYzh61jHRi5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1760549139; x=1760635539; bh=0 /eMc4c5Ol9ee4bJ9dnyfdMjbncOkbk8BlSP7Zc7E8A=; b=cBxj8dwfaS27GGqWd X+0HBPVl/neuW8cO+tOGa1Jiu9V/SHxmgz0LF7yuERUgyNAR9q42YGonddmy/hLu 2JgcN0pDAH2r36Xic3qhErwB02RYF2lqQJ7P+LjHDARJFFAekJb5gFcXrt43mbC2 yDNJNsfPrEhCzWwvLbD9wH496vJer5UFK9z8UV3W7cVNKJx9ytcFRW2CjqkUdvQ1 j+7YNR+KjjKzKZ6Pas/ZcWQo6qJg7Ls2Qq+AZG3+TXMnIGinnimoTUoOP6fhZ0Hv sujcxBob2Dy5302gTScMOEvt6sQiTZsorqPGz+sIKkmnY32zYsIIKuIx6oigoFJt fOJDA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduvdegtddtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheplmhlvhgrrhho ucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsehkuhhrihhlvghmuhdruggvqeenucggtf frrghtthgvrhhnpeetuedvheffkeevgfeuheevteevkefggedttdeufeeuheduuddthfef fffhjeefffenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgv sehkuhhrihhlvghmuhdruggvpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpoh huthdprhgtphhtthhopegrkhhshhgrhidrjhhoshhhihesvghnthgvrhhprhhishgvuggs rdgtohhmpdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrshesphhoshhtghhrvghsqh hlrdhorhhg X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 15 Oct 2025 13:25:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1760549137; bh=zkGkAFDZLAO+ZpdsshiVLyL4d9Jv5AWWfHpfCIfwqUM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=1w/4h+nEgnj8TAyIYem1gKH/zQlXfN7aNYsKAPBEHz1Q1aRr/P3S2NpDlE64kC0Je uuTQDXa2GaN+AfPi/QHAvpfmzf7e4EeopwXBwUMy4FDyOb22mYLqRvw5lJbfqa3O0Q 3ZJ85cCjFYhSwskMLzIJJxvuQ+v14U1ZfWkv0976HxWkDV9jhiSCL+rQA8CFPB5YIH +7bTh2in6yL4wH1e1OJnIj8UGKu1h//uAgPaEHVDvG6wEERuHCAr1dzFg4VqXK7MQR CdzqeO9uzH9NMvy2KG834dcwCKRFGfjg5voJbSuPpUa33hhszp7TSoglKaf0x+gh6A 7EAE/19sW5NTw== Received: by schmee.kurilemu.internal (Postfix, from userid 1000) id 8A0E176; Wed, 15 Oct 2025 19:25:37 +0200 (CEST) Date: Wed, 15 Oct 2025 19:25:37 +0200 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Akshay Joshi Cc: pgsql-hackers Subject: Re: [PATCH] Add pg_get_policy_ddl() function to reconstruct CREATE POLICY statement Message-ID: <202510151529.s3fpwsgben57@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hello, I have reviewed this patch before and provided a number of comments that have been addressed by Akshay (so I encourage you to list my name and this address in a Reviewed-by trailer line in the commit message). One thing I had not noticed is that while this function has a "pretty" flag, it doesn't use it to pass anything to pg_get_expr_worker()'s prettyFlags argument, and I think it should -- probably just prettyFlags = GET_PRETTY_FLAGS(pretty); same as pg_get_querydef() does. Thanks -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/