Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: [PATCH] Add pg_get_policy_ddl() function to reconstruct CREATE
 POLICY statement
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CANxoLDcGLSHDj8Ve0qyM2UWMdgSFJA-28j7dEAtMBey8D_ktdA@mail.gmail.com>
Date: Tue, 21 Oct 2025 17:08:32 +0800
Cc: Philip Alger <paalger0@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <15389F54-0234-412A-ADEE-78B810A35E2B@gmail.com>
References: 
 <CANxoLDdJsRJqnjMXV3yjsk07Z5iRWxG-c2hZJC7bAKqf8ZXj_A@mail.gmail.com>
 <CAPXBC8+i=c7FCcGr6OR0y=mcx3EfdXuxyk_XYgSQ7+egGvb8vA@mail.gmail.com>
 <CANxoLDdef6wW=T5czPSKPsk3xWeEHTeKxxxYMucmr-HURyoOgQ@mail.gmail.com>
 <CAPXBC8J-ZBqaUh7ZcC-SBzTiOZG8P7ssUx6eLKYzVNkzKajpzQ@mail.gmail.com>
 <CANxoLDcGLSHDj8Ve0qyM2UWMdgSFJA-28j7dEAtMBey8D_ktdA@mail.gmail.com>
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/15389F54-0234-412A-ADEE-78B810A35E2B%40gmail.com>
Precedence: bulk


> On Oct 16, 2025, at 20:50, Akshay Joshi =
<akshay.joshi@enterprisedb.com> wrote:
>=20
> Please find attached the v3 patch, which resolves all compilation =
errors and warnings.
>=20
> On Thu, Oct 16, 2025 at 6:06=E2=80=AFPM Philip Alger =
<paalger0@gmail.com> wrote:
> Hi Akshay,
>=20
>=20
> As for the statement terminator, it=E2=80=99s useful to include it, =
while running multiple queries together could result in a syntax error. =
In my opinion, there=E2=80=99s no harm in providing the statement =
terminator.
> However, I=E2=80=99ve modified the logic to add the statement =
terminator at the end instead of appending to a new line.=20
>=20
>=20
> Regarding putting the terminator at the end, I think my original =
comment got cut off by my poor editing. Yes, that's what I was referring =
to; no need to append it to a new line.=20
>=20
> --=20
> Best, Phil Alger
> <v3-0001-Add-pg_get_policy_ddl-function-to-reconstruct-CREATE.patch>

1 - ruleutils.c
```
+	if (pretty)
+	{
+		/* Indent with tabs */
+		for (int i =3D 0; i < noOfTabChars; i++)
+		{
+			appendStringInfoString(buf, "\t");
+		}
```

As you are adding a single char of =E2=80=98\t=E2=80=99, better to use =
appendStringInfoChar() that is cheaper.

2 - ruleutils.c
```
+	initStringInfo(&buf);
+
+	targetTable =3D relation_open(tableID, AccessShareLock);
```

Looks like only usage of opening the table is to get the table name. In =
that case, why don=E2=80=99t just call get_rel_name(tableID) and store =
the table name in a local variable?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/