Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 14 Jun 2023 06:56:42 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: "Wei Wang (Fujitsu)" <wangw.fnst@fujitsu.com>,
	shveta malik <shveta.malik@gmail.com>,
	"Yu Shi (Fujitsu)" <shiy.fnst@fujitsu.com>,
	vignesh C <vignesh21@gmail.com>,
	"Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>,
	Ajin Cherian <itsajin@gmail.com>, Runqi Tian <runqidev@gmail.com>,
	Peter Smith <smithpb2250@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	li jie <ggysxcq@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	Japin Li <japinli@hotmail.com>,
	rajesh singarapu <rajesh.rs0541@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Zheng Li <zhengli10@gmail.com>
Subject: Re: Support logical replication of DDLs
Message-ID: <ZIjmGhPWdoJUfjjE@paquier.xyz>
References: 
 <OSZPR01MB63102C42A24D59FACF6D9CD6FD4A9@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <CAJpy0uCbwqWj+p_yj1AHyiufzAUv_H29qOaztAXxFoTqZ9WcAw@mail.gmail.com>
 <OSZPR01MB6310E0509F229AF2A9414BB1FD499@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <CAJpy0uBwCZCniPR6vh26L+wpSf4xzUN8omUa9DzF-x1CAud_xA@mail.gmail.com>
 <CAA4eK1LOr+2O+_pWKTaa0y9vbW6whfm-8-fuBvnS6OBiaR+7TA@mail.gmail.com>
 <CAA4eK1LF3EaCSj5iqO0oT1k3ew7YnQbbKEgbzORDAdvdtd+r7w@mail.gmail.com>
 <CAJpy0uDtrxPo127LH3FP-TffynrspPFqhhC7o_GFOMP+2mPtWQ@mail.gmail.com>
 <OS3PR01MB6275328379FBE5734B4585619E54A@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <ZIgf3qBvFoTsMhIc@paquier.xyz>
 <CAA4eK1J8WOK9VZ9RpQRNRhRYhFOKQCu=GLCu+iBOePNO3JwLbQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="vJa+5CyBMK1k+orO"
Content-Disposition: inline
In-Reply-To: 
 <CAA4eK1J8WOK9VZ9RpQRNRhRYhFOKQCu=GLCu+iBOePNO3JwLbQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZIjmGhPWdoJUfjjE%40paquier.xyz>
Precedence: bulk


--vJa+5CyBMK1k+orO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jun 13, 2023 at 06:49:42PM +0530, Amit Kapila wrote:
> We have to choose one of the approaches between 0001 and 0008. I feel
> we don't need an intermediate ObjTree representation as that adds
> overhead and an additional layer which is not required. As mentioned
> in my previous email I think as a first step we should merge 0001 and
> 0008 and avoid having an additional ObjTree layer unless you or others
> feel we need it. I think that will reduce the overall patch size and
> help us to focus on one of the approaches.

Similar impression here.  I found ObjTree actually confusing compared
to the JSON blobs generated.

> Surely, as suggested by
> you, we should also evaluate if we can generate this code for the
> various command types.

Thanks.
--
Michael

--vJa+5CyBMK1k+orO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSI5hoACgkQnvQgOdby
QH3byxAAlGCE92pZJzfQQxRG4Bm4sntctPOoeQ629IbwEt+eMQY62ql47tf0lOie
1GtUY8fAY3oZFUWR5nowPG4xvwuOCd0VVpJFb2SL/NpUxEFzLFUnlN1h+Cni0u0X
oT4msy45+8lw51Z5t4TarWN6rGhjX9LC+Qa9BzqoahStpOhu/QbEtTSlKUWAF9XS
yQxDyJ3XXaBSnhzw23LJCtJ5dd7NSXhogmudltICxZOyn6KxirGQVwQBZLdtPiu9
W80opv8m5NefDPG0+BDAEQdH3VLiUCbb5H4xhRGlHY81pfHrdfL0vvMiJg7s+KMc
LFT767Jyw6C7ISUW6JVbORKGp8XeyV29gXxlCecuXc2+M+OG4LPXk0MA18kGDObj
r8Nc/mmAhroyqcCjf+Ac9YOHE12AG0vmavP0Bk7ZrtuQ4iJIFvKPoui4nQ11RRbl
dftke1MXLv+S9iz6jDIECbM6g0DyTslG+RhR4INWuzggFZZQW4UdY5Ru0u+3DGEo
iUx2xU/QGd/T4LX+TH3TC9XgWGtsfSY+42t8/cAsl3C0M6eAxb2kv1bvpX0a7dvp
QlpwtVCkEJm3ypSzcBL1e4AKhuyKOiz08Yad5hO0ldpqVTl2XMSwlb8gBf/EthZL
XymIwRMFbFEJkorg2fhcdnpowjwHHbJo/Hi+yd5p/y/5s0epHRY=
=T7FN
-----END PGP SIGNATURE-----

--vJa+5CyBMK1k+orO--