public inbox for pgsql-general@postgresql.org
help / color / mirror / Atom feedFrom: Yu Shi (Fujitsu) <shiy.fnst@fujitsu.com>
To: shveta malik <shveta.malik@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>
Cc: Ajin Cherian <itsajin@gmail.com>
Cc: Wei Wang (Fujitsu) <wangw.fnst@fujitsu.com>
Cc: Runqi Tian <runqidev@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: li jie <ggysxcq@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Japin Li <japinli@hotmail.com>
Cc: rajesh singarapu <rajesh.rs0541@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Zheng Li <zhengli10@gmail.com>
Subject: RE: Support logical replication of DDLs
Date: Thu, 1 Jun 2023 07:39:51 +0000
Message-ID: <OSZPR01MB6310E0509F229AF2A9414BB1FD499@OSZPR01MB6310.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAJpy0uCbwqWj+p_yj1AHyiufzAUv_H29qOaztAXxFoTqZ9WcAw@mail.gmail.com>
References: <CALDaNm3zSxK1g0UTo4RjPR3JEc-vyPzANOnKEKjiW88xtUUdzA@mail.gmail.com>
<CAJpy0uCGnRQnpNVQaApRxqN=9t5VpHRk5b+Mfdf3cqCEW=s+4A@mail.gmail.com>
<OSZPR01MB63102C42A24D59FACF6D9CD6FD4A9@OSZPR01MB6310.jpnprd01.prod.outlook.com>
<CAJpy0uCbwqWj+p_yj1AHyiufzAUv_H29qOaztAXxFoTqZ9WcAw@mail.gmail.com>
On Wed, May 31, 2023 5:41 PM shveta malik <shveta.malik@gmail.com> wrote:
>
> On Mon, May 29, 2023 at 11:45 AM Yu Shi (Fujitsu) <shiy.fnst@fujitsu.com>
> wrote:
> >
> > 0008 patch
> > -----
> > 4.
> > case AT_AddColumn:
> > /* XXX need to set the "recurse" bit somewhere? */
> > Assert(IsA(subcmd->def, ColumnDef));
> > - tree = deparse_ColumnDef(rel, dpcontext, false,
> > - (ColumnDef *) subcmd->def, true,
> &expr);
> >
> > mark_function_volatile(context, expr);
> >
> > After this change, `expr` is not assigned a value when mark_function_volatile is
> called.
> >
>
> Corrected.
>
It looks the call to mark_function_volatile() is removed in this case. I think
we still need it, otherwise we won't know if the command contains a volatile
function. (see check_command_publishable().)
> > 5.
> > create table p1(f1 int);
> > create table p1_c1() inherits(p1);
> > alter table p1 add constraint inh_check_constraint1 check (f1 > 0);
> > alter table p1_c1 add constraint inh_check_constraint1 check (f1 > 0);
> >
> > The re-formed command of the last command is "ALTER TABLE public.p1_c1",
> which
> > seems to be wrong.
> >
>
> Fixed, second alter-table should actually be no-op in terms of
> deparsing. But when it is run without running the first alter-table
> command, it should generate the reformed command.
>
If the second alter-table is no-op in terms of deparsing, the dumped result of
origin command and that of re-formed command will be different. This seems to be
because `conislocal` column of pg_constraint has different values. (After the
second alter-table, its value is changed from false to true.)
Regards,
Shi Yu
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-general@postgresql.org
Cc: shiy.fnst@fujitsu.com, shveta.malik@gmail.com, vignesh21@gmail.com, amit.kapila16@gmail.com, houzj.fnst@fujitsu.com, itsajin@gmail.com, wangw.fnst@fujitsu.com, runqidev@gmail.com, smithpb2250@gmail.com, tgl@sss.pgh.pa.us, ggysxcq@gmail.com, dilipbalaut@gmail.com, alvherre@alvh.no-ip.org, sawada.mshk@gmail.com, japinli@hotmail.com, rajesh.rs0541@gmail.com, pgsql-hackers@lists.postgresql.org, zhengli10@gmail.com
Subject: RE: Support logical replication of DDLs
In-Reply-To: <OSZPR01MB6310E0509F229AF2A9414BB1FD499@OSZPR01MB6310.jpnprd01.prod.outlook.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox