References: 
 <CAAD30ULtoGp8L_GKbV15Wnm+X5r=SE7MOnYHuqBr396m26jJSA@mail.gmail.com>
 <202203162206.7spggyktx63e@alvherre.pgsql>
 <CAAD30UKRUusq8JyyHzAv71=ncN22OE8OkOOyAWvRHW3wXNjyyA@mail.gmail.com>
 <CAAD30UKTp87+kvGZYL3M2Suxq=WEvFUG24ZRT0yT9rqdkP=uMA@mail.gmail.com>
 <MEYP282MB1669863D5C31D7F6A1D996D8B6139@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
 <CAAD30UKc=GiGQzE8H7+Ofo18hwMOfK4qUm_KUyw6c09q4JvA5Q@mail.gmail.com>
User-agent: mu4e 1.4.14; emacs 27.1
From: Japin Li <japinli@hotmail.com>
To: Zheng Li <zhengli10@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Dilip Kumar
 <dilipbalaut@gmail.com>, rajesh.rs0541@gmail.com, PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>
Subject: Re: Support logical replication of DDLs
In-reply-to: 
 <CAAD30UKc=GiGQzE8H7+Ofo18hwMOfK4qUm_KUyw6c09q4JvA5Q@mail.gmail.com>
Date: Sat, 19 Mar 2022 07:33:29 +0800
Message-ID: 
 <MEYP282MB16691E383140844437FB0633B6139@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6cfdcc9f-0e47-423d-8da3-08da0937b822
X-MS-TrafficTypeDiagnostic: SY6P282MB3434:EE_
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	tWZ49ApFWBS7RC88vhrh07HYyohyG+DL5pPet9MRT+JfYIyIITYXc/wiLZsSxHijInZKma4C/pu6TqOUVV1KD0pVRc70LMs8x9l+h/QMbqw42xBonESXIJ4hLiu0jyXMoY297k8D/0slVfgWHQ756B0iKM8eu4BgD+FUge5bZ2ssvqGn60q93LWwQazOvJluxh3giAVkt6nDv/UPf+AAs8zztX6Mznys6uOJr3rWbaZ+Ue0iI4Zdn6Zxq1U2KY4KjVO3Q1mDpsFic25BdNka3RADAGPPsFS2WSMdJayXTWVWNgWK37i6vUNBQhN1aEWSrXi8iFzUHc63PPmooS5gXAPRc9TMSJM8MtZtNhEIS557u+0YSvv/ZkLbab+uwu3CPnc/dc9DI+crHZdzZms/T2DIRVjmDa5ZkpU2NBetv8VV6mkYiuUPk1Z0kK+iAmKh7opENwxzrL4bcBIdFaOeiC0yOGW4NRyCwQwiJeIdxR0maOsdxFiJup2Qllf6vk3ThFTkFsoWfbFmwNmPAesn8eGIXoO1GfBiRFE8suJAjyfeqXy0Bl/ifkE8076DuhTQK/n2d02Z8EMbReWH1vjjFpT+ah/07QiWcoY0FrFT92GAbCjKILtePZTWcbfGyJwe
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?MP65Lxm3E3nmgQztRon++cmLXU4xkw58X5gXYFWAud0kDQ3iRQKOSuqwD9aP?=
 =?us-ascii?Q?dea39JAz3AfIR+yKM7tceZOOeReWRctl/DdqFNJMItE/nKtqqKs51yOOcB0B?=
 =?us-ascii?Q?pGEx2c+JpCAdh8bqtW350IS/8KJ3NNevFfMqeLODKj0k7AgwsfStC3M051LO?=
 =?us-ascii?Q?KmkPM51UmhQXvdsFgHu+Zle2pOPyKhixEMaQ9ERmetW8bO5duEfuB9ftryKO?=
 =?us-ascii?Q?gv1kgIJsKD8+OOEaILNaS4oHtjT376tis+1b+92bBKSHtAMZR6ct82gYB8oI?=
 =?us-ascii?Q?NLqWVnR+9uDwkFMoLxV0Lb1sElf4f/+yGrDJfNfoAkdbwwjPfBBibGHQV1fB?=
 =?us-ascii?Q?7ZpXnRWbQqjLSo0cBXj9oaxtEz3ePiBW2ZcNojQFyk7oJqWiCJZFdIm2t2Jq?=
 =?us-ascii?Q?YzKxzxYMDoXPqbWlqu0epym5yVXfHbtUpogKBrYvxfCg3XC3cX3UMvaRJY2o?=
 =?us-ascii?Q?i564PapJFVTexP4DY3Hi+VKnsDNuPcaZ8sddgXw9Xg7GcWFImaPopX+T7lW5?=
 =?us-ascii?Q?ayHizsmO3Y5j/dXqyqdLrp/CM+Sul3iqDEsPVo9FIWXYTWTMrtqzlcu3OV+Q?=
 =?us-ascii?Q?ZzXzGn+5ylJ8RkjLakLzdRZKoMU9upYFC1qLL569tYNHbqzBPNIrQorufgIr?=
 =?us-ascii?Q?lF77w6EALvOJSRUyb4nH9NTNojq6+rXpLFFJQeas/LLxMB/q5/d9QhZdWLSq?=
 =?us-ascii?Q?0WpXWgAojgswhcLvzflqDXwoxWnB4uGQ3JKbkeNTZuk8vE67a5+TuZmjqEjD?=
 =?us-ascii?Q?KjwZtKpfReJc8scGyVIXPphbw/GZXlZ+EdwywpCCUpYkqPw464JYmIxGKv2F?=
 =?us-ascii?Q?YsiBeMKBw1SEwW5VHzhJViT0QPqEk9WUICCx3Gu/XOnefUs+NROFUr+tv5yx?=
 =?us-ascii?Q?0lrwIGn5bnMQUtBsYZI+l14NvpW1BF/+UUTp00AwtyLQI9NSm8K+Lwln2qpV?=
 =?us-ascii?Q?LrIKIx/Z7U1fx4EAn8+YNdn/NnoxBscsJAEiTSlYey/nUrkPRNOrq3RYDtAZ?=
 =?us-ascii?Q?+0Q2i2cBHOEUJqgfI+9yuPuqTWxS7TayCnMbTbbOCCVqpmAneDdK9RXA0dwy?=
 =?us-ascii?Q?zaiPqNVLKdXpcvrS4QiAfLensHqojToVjIPD1VeqF+2l75nE7MJ2F2pNGK0X?=
 =?us-ascii?Q?CX7Ie3+0v8kyv6caWiKbYmkcEfZX382fSQ=3D=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 6cfdcc9f-0e47-423d-8da3-08da0937b822
X-MS-Exchange-CrossTenant-AuthSource: MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2022 23:33:34.7208
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY6P282MB3434
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/MEYP282MB16691E383140844437FB0633B6139%40MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
Precedence: bulk


On Sat, 19 Mar 2022 at 01:25, Zheng Li <zhengli10@gmail.com> wrote:
> Hello,
>
> Thanks for the quick review!
>
>> And, when I try to use git am to apply the patch, it complains:
>>
>>         $ git am ~/0001-syntax-pg_publication-pg_dump-ddl_replication.patch
>>         Patch format detection failed.
>
> git apply works for me. I'm not sure why git am complains.
> I also created a git branch to make code sharing easier, please try this out:
> https://github.com/zli236/postgres/tree/ddl_replication
>

Yeah, I can use git apply, I'm not sure how did you generate the patch.


>> I also think that ddl = '' isn't a good way to disable DDL replication, how
>> about using ddl = 'none' or something else?
>
> The syntax follows the existing convention of the WITH publish option.
> For example in CREATE PUBLICATION mypub WITH (publish = '')
> it means don't publish any DML change. So I'd leave it as is for now.
>

Agreed.

>> The test_decoding test case cannot work as expected, see below:
> .....
>>   DDL message: transactional: 1 prefix:  role: redacted, search_path: "$user", public, sz: 47 content:CREATE TABLE tab1 (id serial unique, data int);
>>   BEGIN
>>   sequence public.tab1_id_seq: transactional:1 last_value: 1 log_cnt: 0 is_called:0
>>
>> Since the DDL message contains the username, and we try to replace the username with 'redacted' to avoid this problem,
>>
>>     \o | sed 's/role.*search_path/role: redacted, search_path/g'
>>
>> However, the title and dash lines may have different lengths for different
>> usernames.  To avoid this problem, how about using a specified username when
>> initializing the database for this regression test?
>
> I don't understand the question, do you have an example of when the
> test doesn't work? It runs fine for me.
>

You should use a different user that has different length from your current one.
For example:

        px@localhost$ make check-world

>
>> t/002_pg_dump.pl .............. 13/?
>> #   Failed test 'binary_upgrade: should dump CREATE PUBLICATION pub1'
>> #   at t/002_pg_dump.pl line 3916.
>> # Review binary_upgrade results in /home/px/Codes/postgresql/Debug/src/bin/pg_dump/tmp_check/tmp_test_jgRI
> ......
>> Failed 84/7709 subtests
>> t/003_pg_dump_with_server.pl .. ok
>> t/010_dump_connstr.pl ......... ok
>>
>> Test Summary Report
>> -------------------
>> t/002_pg_dump.pl            (Wstat: 21504 Tests: 7709 Failed: 84)
>
> This is fixed in the latest version. I need to remind myself to run
> make check-world in the future.
>

Thanks for updating the patch.

--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.