Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pAfGL-0002FL-Fu
	for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Dec 2022 22:51:05 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pAfGK-0005Y4-7R
	for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Dec 2022 22:51:04 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <zhengli10@gmail.com>)
	id 1pAfGJ-0005Xu-T5
	for pgsql-hackers@lists.postgresql.org; Wed, 28 Dec 2022 22:51:03 +0000
Received: from mail-yb1-xb2e.google.com ([2607:f8b0:4864:20::b2e])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.92)
	(envelope-from <zhengli10@gmail.com>)
	id 1pAfGH-0003oC-Iq
	for pgsql-hackers@lists.postgresql.org; Wed, 28 Dec 2022 22:51:03 +0000
Received: by mail-yb1-xb2e.google.com with SMTP id 188so2503855ybi.9
        for <pgsql-hackers@lists.postgresql.org>;
 Wed, 28 Dec 2022 14:51:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=WW+scqzMgV5WwHxXOicMEM/HoDnNouMz/rsKIJPXc0Y=;
        b=pxPiyP2Gk6ezmqOKqvh9E1PQcYnNDSDddVa4XfMegdT9wPZH5RAgg11oOo5NBxDADv
         kPa+dAIbtvAVEMQe4UHXQCB1qZd8VmJmk3Tb+sY5QcxkDI2U10kmix6dbDn/0XBm9tLE
         XMLupDlHmI3B6cdYsqG7ac2akUlBdkOie7k0Txxc6D1g1/br1ZwBdA2OdaBwSruLVkYZ
         nsNfdz3pMC12GNcL68P6x12Iyt5gBttbQ2X/6nmqdWU3d08StKhg+SlKWxmHLnO4j+ND
         xZFl14zvy6jxD0yE6hJcxJOrgy2L3ZEZJuArq0LkbcbVbHIFVSREKRN+7vO8rSCVs7fe
         ojpg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=WW+scqzMgV5WwHxXOicMEM/HoDnNouMz/rsKIJPXc0Y=;
        b=DZ5eZ/04kw7zLpTLmSySVnWsMPstIVVT9ncNBQEHuWV2UD4vYOGN7cMrKqYu/w3YLh
         I9lZ6JeUS8aaubzdzMLPkCpzq5jkAr8P04qp1BEAeQb3XDmy57F6vTt13bG+lkP9Y4A1
         xUJ0a35TolYtU2nmNlCASdc6vVFnkNBi3n6V30QmaYe3hdxI3iuAKKQipprQWn+bD68g
         ZXVfzAISN6O4zg4AwMmFup7jc/FWJeLDWZ1Tla6jzOuhPrC+OB8W/SOkv/cC9RJ2f2IO
         G20EVZK+dOS7o8LemB4uZ/fi5RIuJTTLdN0/bIxccq7DE170aM258Nn+K1JJWztqKrZV
         TTkg==
X-Gm-Message-State: AFqh2kq7vB+vD0VBk13A5BS3NlCiBqNoZ5sp80fkTCwalQjK+A1aLqGa
	3cj/Suw3udCReuirg6Pr//SA4diayKKvimOj9KA=
X-Google-Smtp-Source: 
 AMrXdXs0+zV56/2Or5U1Q8otP+fhsHW1UF8YAmfU3IALBcEz1S1NneR/Qm4eAwwRgk6S3MGtStVhb3e+c7WZwIR3Ni8=
X-Received: by 2002:a25:c010:0:b0:6cb:7f63:c664 with SMTP id
 c16-20020a25c010000000b006cb7f63c664mr1980863ybf.263.1672267859329; Wed, 28
 Dec 2022 14:50:59 -0800 (PST)
MIME-Version: 1.0
References: 
 <CAAD30UKg8rXeGM8Oy_MAmxKBL_K5DiHXdeNF=hUefcu1C_6VfQ@mail.gmail.com>
 <20221006171601.6um4ey5idm4h62vf@alvherre.pgsql>
 <CAAD30UJh+LcUND+zg_A5dbQ_Bi=m_n7qUfKrOwAx2v4jBKWvKQ@mail.gmail.com>
 <CAFPTHDbVujj6C3TdMCmoBXovpc4=5Ow3i5M1_HNhmnqdiA5qSA@mail.gmail.com>
 <CAAD30UKCCpMTZd4WSSxYu-qRAEFd+0kjXTgje+EXHdo1JTkz0g@mail.gmail.com>
 <CALDaNm3F9GvQ9bPrxobhqkUKP3HmrRZGCU3EX0xt3=Ef0-Reaw@mail.gmail.com>
 <CAFPTHDY2O42ouQFMeEbPt51CWQ=zyzYhgK6B9basyd5PLaOv0A@mail.gmail.com>
 <CAFPTHDZmS2PrOyJx8OAe+Nt-Fx4-GZetJatqCEJhDNXA2orwCg@mail.gmail.com>
 <CAFiTN-tWkJW-JEGANkK+O3KXUjv_Yb5Tb+r83ujbognHG_brTA@mail.gmail.com>
 <CALDaNm08gZq9a7xnsbaJMmHmi29_kbEuyShHHfxAKLXPh6btWQ@mail.gmail.com>
 <CAFPTHDbGRpXOF-j+oemm=xkzjrh-ZnqPV7SMS_+QBPYdUwhWxg@mail.gmail.com>
 <CAAD30UL=wV7pvdwJ6w5UQUc3urHs6W2vnomK2MKUyek3rzsKcA@mail.gmail.com>
 <CAHut+Psm+9q++y8b70QTeBeZiYcfDNtc_obxSwhxukp0MFhnRA@mail.gmail.com>
 <CAHut+PsO0dwWoB4B6L3Ucd6D8ckgdXY2Sd3JK7F_3wLsXU7ZAg@mail.gmail.com>
 <CAHut+Puxo_kq2toicNK_BQdeccK3REGW-Xv8tVauFvTNku6V-w@mail.gmail.com>
 <CAHut+Pu6H6hY0JJNNRCRmFpM_3817z=0xjm-_ibP+cL85pBOpQ@mail.gmail.com>
 <CALDaNm3q_2Qfo4XbFkBT8mPz_ALS2MyuR=isP7_8Pz27JnLHiw@mail.gmail.com>
 <CAGfChW5Qbb8WKznzVqp+cyTqkzLt_vEeSe14td14et6HjnH7qw@mail.gmail.com>
 <CAAD30UKwHmLo1YyjB1j_vCEth0+OS9hkLr9Nrrsw5uwEuOs=+g@mail.gmail.com>
 <CALDaNm2V6YL6H4P9ZT95Ua_RDJaeDTUf6V0UDfrz4_vxhM5pMg@mail.gmail.com>
 <CAAD30ULrZB-RNmuD3NMr1jGNUt15ZpPgFdFRX53HbcAB76hefw@mail.gmail.com>
In-Reply-To: 
 <CAAD30ULrZB-RNmuD3NMr1jGNUt15ZpPgFdFRX53HbcAB76hefw@mail.gmail.com>
From: Zheng Li <zhengli10@gmail.com>
Date: Wed, 28 Dec 2022 17:50:48 -0500
Message-ID: 
 <CAAD30UL0EmSGk58eZxxYzFTQ5EqSpX6d+OcX5MuE0j0r2ZgyDA@mail.gmail.com>
Subject: Re: Support logical replication of DDLs
To: vignesh C <vignesh21@gmail.com>
Cc: li jie <ggysxcq@gmail.com>, Peter Smith <smithpb2250@gmail.com>,
	Ajin Cherian <itsajin@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
 "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
 Masahiko Sawada <sawada.mshk@gmail.com>,
	Japin Li <japinli@hotmail.com>, rajesh singarapu <rajesh.rs0541@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/CAAD30UL0EmSGk58eZxxYzFTQ5EqSpX6d%2BOcX5MuE0j0r2ZgyDA%40mail.gmail.com>
Precedence: bulk

On Wed, Dec 28, 2022 at 5:42 PM Zheng Li <zhengli10@gmail.com> wrote:
>
> >- CreatePublication has a long list of command tags; is that good?
> >Maybe it'd be better to annotate the list in cmdtaglist.h somehow.
>
> I've addressed this comment by introducing a new flag ddlreplok in the
> PG_CMDTAG macro and modified CreatePublication accordingly.

I notice the support for the following commands are missing while
moving the command tags, will look into it:
CMDTAG_CREATE_AGGREGATE
CMDTAG_ALTER_AGGREGATE
CMDTAG_DROP_AGGREGATE
CMDTAG_DROP_TRIGGER
CMDTAG_DROP_USER_MAPPING

Zane