public inbox for pgsql-docs@postgresql.org
help / color / mirror / Atom feedchange ON CONFLICT UPDATE
4+ messages / 3 participants
[nested] [flat]
* change ON CONFLICT UPDATE
@ 2025-11-25 14:47 jian he <jian.universality@gmail.com>
2025-11-26 09:52 ` Re: change ON CONFLICT UPDATE Laurenz Albe <laurenz.albe@cybertec.at>
0 siblings, 1 reply; 4+ messages in thread
From: jian he @ 2025-11-25 14:47 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org
hi.
in doc/src/sgml/ref/create_view.sgml,
I want change two occurrences of
<literal>ON CONFLICT UPDATE</literal>
to
<literal>ON CONFLICT DO UPDATE</literal>
(between line 412 to line 439).
since other places using <literal>ON CONFLICT DO UPDATE</literal>.
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: change ON CONFLICT UPDATE
2025-11-25 14:47 change ON CONFLICT UPDATE jian he <jian.universality@gmail.com>
@ 2025-11-26 09:52 ` Laurenz Albe <laurenz.albe@cybertec.at>
2025-12-23 00:42 ` Re: change ON CONFLICT UPDATE Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 4+ messages in thread
From: Laurenz Albe @ 2025-11-26 09:52 UTC (permalink / raw)
To: jian he <jian.universality@gmail.com>; pgsql-docs@lists.postgresql.org
On Tue, 2025-11-25 at 22:47 +0800, jian he wrote:
> in doc/src/sgml/ref/create_view.sgml,
> I want change two occurrences of
> <literal>ON CONFLICT UPDATE</literal>
> to
> <literal>ON CONFLICT DO UPDATE</literal>
> (between line 412 to line 439).
>
> since other places using <literal>ON CONFLICT DO UPDATE</literal>.
+1
It is not very important, but consistency is always good.
Here is a patch for that.
Yours,
Laurenz Albe
Attachments:
[text/x-patch] v1-0001-Doc-use-ON-CONFLICT-DO-UPDATE-everywhere.patch (1.9K, 2-v1-0001-Doc-use-ON-CONFLICT-DO-UPDATE-everywhere.patch)
download | inline diff:
From d33e095ee9821d8cd55836c98c083502fee2e932 Mon Sep 17 00:00:00 2001
From: Laurenz Albe <laurenz.albe@cybertec.at>
Date: Wed, 26 Nov 2025 10:49:51 +0100
Subject: [PATCH v1] Doc: use ON CONFLICT DO UPDATE everywhere
Two places in the CREATE VIEW reference page used
ON CONFLICT UPDATE instead. Better be consistent.
Author: Laurenz Albe <laurenz.albe@cybertec.at>
Reported-By: jian he <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxEW1RRDD9ZWGcW_Np_Z9VGPE-YC7u0C6RcsEY8EKiTdBg%40mail.gmail.com
---
doc/src/sgml/ref/create_view.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/ref/create_view.sgml b/doc/src/sgml/ref/create_view.sgml
index 7b6b750c6de..f8a4740608a 100644
--- a/doc/src/sgml/ref/create_view.sgml
+++ b/doc/src/sgml/ref/create_view.sgml
@@ -415,7 +415,7 @@ CREATE VIEW vista AS SELECT text 'Hello World' AS hello;
<command>DELETE</command>, or <command>MERGE</command> statement
on the view into the corresponding statement on the underlying base
relation. <command>INSERT</command> statements that have an <literal>ON
- CONFLICT UPDATE</literal> clause are fully supported.
+ CONFLICT DO UPDATE</literal> clause are fully supported.
</para>
<para>
@@ -430,7 +430,7 @@ CREATE VIEW vista AS SELECT text 'Hello World' AS hello;
an <command>INSERT</command> or <command>MERGE</command> command can
potentially insert base-relation rows
that do not satisfy the <literal>WHERE</literal> condition and thus are not
- visible through the view (<literal>ON CONFLICT UPDATE</literal> may
+ visible through the view (<literal>ON CONFLICT DO UPDATE</literal> may
similarly affect an existing row not visible through the view).
The <literal>CHECK OPTION</literal> may be used to prevent
<command>INSERT</command>, <command>UPDATE</command>, and
--
2.51.1
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: change ON CONFLICT UPDATE
2025-11-25 14:47 change ON CONFLICT UPDATE jian he <jian.universality@gmail.com>
2025-11-26 09:52 ` Re: change ON CONFLICT UPDATE Laurenz Albe <laurenz.albe@cybertec.at>
@ 2025-12-23 00:42 ` Bruce Momjian <bruce@momjian.us>
2025-12-23 10:19 ` Re: change ON CONFLICT UPDATE Laurenz Albe <laurenz.albe@cybertec.at>
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Momjian @ 2025-12-23 00:42 UTC (permalink / raw)
To: Laurenz Albe <laurenz.albe@cybertec.at>; +Cc: jian he <jian.universality@gmail.com>; pgsql-docs@lists.postgresql.org
On Wed, Nov 26, 2025 at 10:52:10AM +0100, Laurenz Albe wrote:
> On Tue, 2025-11-25 at 22:47 +0800, jian he wrote:
> > in doc/src/sgml/ref/create_view.sgml,
> > I want change two occurrences of
> > <literal>ON CONFLICT UPDATE</literal>
> > to
> > <literal>ON CONFLICT DO UPDATE</literal>
> > (between line 412 to line 439).
> >
> > since other places using <literal>ON CONFLICT DO UPDATE</literal>.
>
> +1
>
> It is not very important, but consistency is always good.
> Here is a patch for that.
Agreed, patch applied, thanks.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: change ON CONFLICT UPDATE
2025-11-25 14:47 change ON CONFLICT UPDATE jian he <jian.universality@gmail.com>
2025-11-26 09:52 ` Re: change ON CONFLICT UPDATE Laurenz Albe <laurenz.albe@cybertec.at>
2025-12-23 00:42 ` Re: change ON CONFLICT UPDATE Bruce Momjian <bruce@momjian.us>
@ 2025-12-23 10:19 ` Laurenz Albe <laurenz.albe@cybertec.at>
0 siblings, 0 replies; 4+ messages in thread
From: Laurenz Albe @ 2025-12-23 10:19 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: jian he <jian.universality@gmail.com>; pgsql-docs@lists.postgresql.org
On Mon, 2025-12-22 at 19:42 -0500, Bruce Momjian wrote:
> Agreed, patch applied, thanks.
Thank you!
Laurenz Albe
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-12-23 10:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-11-25 14:47 change ON CONFLICT UPDATE jian he <jian.universality@gmail.com>
2025-11-26 09:52 ` Laurenz Albe <laurenz.albe@cybertec.at>
2025-12-23 00:42 ` Bruce Momjian <bruce@momjian.us>
2025-12-23 10:19 ` Laurenz Albe <laurenz.albe@cybertec.at>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox