Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vVHr5-00HaQq-0p for pgsql-docs@arkaria.postgresql.org; Mon, 15 Dec 2025 23:19:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vVHr3-0036gr-2Y for pgsql-docs@arkaria.postgresql.org; Mon, 15 Dec 2025 23:19:50 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vVHr3-0036gh-1I for pgsql-docs@lists.postgresql.org; Mon, 15 Dec 2025 23:19:50 +0000 Received: from mail-oo1-xc29.google.com ([2607:f8b0:4864:20::c29]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vVHr1-000wlI-0d for pgsql-docs@lists.postgresql.org; Mon, 15 Dec 2025 23:19:49 +0000 Received: by mail-oo1-xc29.google.com with SMTP id 006d021491bc7-657a6028fbbso2219139eaf.3 for ; Mon, 15 Dec 2025 15:19:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=illuminatedcomputing-com.20230601.gappssmtp.com; s=20230601; t=1765840785; x=1766445585; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HX767mOcnbicUCZfKVOcdFFp+QJwwnH2U8zibyMZ6Cc=; b=nNmJxT0LvgRF6kvzHN0E1BLGuQ+IDBb4cDyHuC4XibF3PqWS43qWVgulaHSOSW2GIC fkkumpdp7HwUQmGmDbAjrqhxjJDLAi85YhrHCBwawYG+UBo/LQxHDCGF9ltjr8UZ33NY FFG7J0lG2UPMlf8QPQtPIYbbSO6Zblf2HZYtoJ9I8qzcS6EZ8IKzDnE4Zo0GCyBfgt98 dQ8B7qkQIc8QGH7SM7s2/S8carIuPgxlPp6cQGGgnyhcI22p+6ZTNE3WvDlUvbMRy/9R yOng9vxvF7eIItpTXaR6l7A6AzJL7Ch0/YYVPR1DP9b7TKOFbKzYnnco1xLveljWiAvO YXQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765840785; x=1766445585; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HX767mOcnbicUCZfKVOcdFFp+QJwwnH2U8zibyMZ6Cc=; b=mwpiIV0SbywGBmo/mYNBSd+t/grbcfN+G8xKfRHk6JYCdtV5ExLG8VStA/oOo4qt9R ywwGoNQwlbVg951cJkD+Wt6/v+cOtJXqZSGwYsi80ufpbrGbNULshe7nGKcrKXWw/6yf /2PEBVER9f9/dxtRGgWhRnnNg4bG52myQ/45lnTVOnB1cYMqxRfcofyt8DYjzBBKEjAx INvZc1hwEfKaRhXdL1g5g7M9rjoe0EbOga2v07P6VMYnY3wqWBTARdk9M/X2DsS9GFDY I6ZpnQXu94uKniFN0uYdgjtmzAgNwDxk5+pQiHY6a5oiBECzHdbpwLgA8jtcqsoY/IbE UvEQ== X-Gm-Message-State: AOJu0Yx+i4S2gTqYo0ZjdTMxYQ5Ra87o9HNpakcATtA5+/sT5NN6wkYv ahRya7uca7VjvtZawSViMR5QwT8geq0uhMx8Ys0k9Yiox5bh8sr/Ki7Zq9m3+g8cvPdBSteGpIp o+TmTTDU6xpj7rHaJCp9flEeEak4+ipbbhQtERj6OnQ== X-Gm-Gg: AY/fxX4zD1/0I5KFQyx0mpitRv6rNoeO7mPRPem8HHXjOqeYe6ulfA2viqC93C1hrZf BDBd/P5+Y1LJd4LBXDT+ZZdnpnCX+ZJM6oTigQLXOeaSIegEpWxLtCQ6M4Y7fC/ikcMXY3fJpHs R2/FhXUkiEAUFUG4fhtOdxGXQaUFCSEaRfsuPZaBEhYoQSeEMEJ5Ddw0yuXyPmlxg5WNItNqiBb LHPx6rzo/qU8wbzvsVCR9F8Tq+UXkN4J8Md+OmtjVi/DSrSOBVuseksagaO6+ckAQjm X-Google-Smtp-Source: AGHT+IEHrAIunde9Az4kARXn7idodKwTpj+zPyN1MrBtnBS1wETTYYcUFmqboZkyM+oSdvOgFE/g4J9Bl1rQvnn2kLc= X-Received: by 2002:a05:6820:1c95:b0:65b:32b4:83e7 with SMTP id 006d021491bc7-65b451863a4mr5297117eaf.19.1765840785205; Mon, 15 Dec 2025 15:19:45 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Paul A Jungwirth Date: Mon, 15 Dec 2025 15:19:34 -0800 X-Gm-Features: AQt7F2qoqutVJLLJaXpxYklw0b1j8S3b7Lp5Q89SHbApz_w96WxHwKpefWDcdhs Message-ID: Subject: Re: doc: Fix the header file where CompareType is defined in gist.sgml To: Daisuke Higuchi Cc: pgsql-docs@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, Dec 13, 2025 at 12:25=E2=80=AFAM Daisuke Higuchi wrote: > > I found that the header file where CompareType was actually defined did n= ot match the header file described in gist.sgml. > CompareType is currently defined at "src/include/access/cmptype.h" instea= d of "src/include/nodes/primnodes.h". > This change was made in the commit below, but it seems that documentation= update was missed. > > https://github.com/postgres/postgres/commit/119fc30dd5bd918819b864107ddc8= baac51f4d22 You're right, that's where we define it. Your email landed in Gmail's spam folder for me, so hopefully this +1 will help it not be missed by a committer. Yours, --=20 Paul ~{:-) pj@illuminatedcomputing.com