Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\))
Subject: Re: doc: Fix the header file where CompareType is defined in
 gist.sgml
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: 
 <CA+renyV6soCRaZGOgyBXoqGQn2E2gT-MuqFoc0jOhw74iMJ6AA@mail.gmail.com>
Date: Tue, 16 Dec 2025 09:50:22 +0100
Cc: Daisuke Higuchi <higuchi.daisuke11@gmail.com>,
 pgsql-docs@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <1256D2D9-8300-4526-9F85-ECB8CA769E59@yesql.se>
References: 
 <CAEVT6c8guXe5P=L_Un5NUUzCgEgbHnNcP+Y3TV2WbQh-xjiwqA@mail.gmail.com>
 <CA+renyV6soCRaZGOgyBXoqGQn2E2gT-MuqFoc0jOhw74iMJ6AA@mail.gmail.com>
To: Paul A Jungwirth <pj@illuminatedcomputing.com>
Archived-At: 
 <https://www.postgresql.org/message-id/1256D2D9-8300-4526-9F85-ECB8CA769E59%40yesql.se>
Precedence: bulk

> On 16 Dec 2025, at 00:19, Paul A Jungwirth =
<pj@illuminatedcomputing.com> wrote:
>=20
> On Sat, Dec 13, 2025 at 12:25=E2=80=AFAM Daisuke Higuchi
> <higuchi.daisuke11@gmail.com> wrote:
>>=20
>> I found that the header file where CompareType was actually defined =
did not match the header file described in gist.sgml.
>> CompareType is currently defined at "src/include/access/cmptype.h" =
instead of "src/include/nodes/primnodes.h".
>> This change was made in the commit below, but it seems that =
documentation update was missed.
>>=20
>> =
https://github.com/postgres/postgres/commit/119fc30dd5bd918819b864107ddc8b=
aac51f4d22
>=20
> You're right, that's where we define it. Your email landed in Gmail's
> spam folder for me, so hopefully this +1 will help it not be missed by
> a committer.

Thanks for the report, fixing it right now.

--
Daniel Gustafsson