public inbox for pgsql-docs@postgresql.org
help / color / mirror / Atom feedFrom: Laurenz Albe <laurenz.albe@cybertec.at>
To: jian he <jian.universality@gmail.com>
To: pgsql-docs@lists.postgresql.org
Subject: Re: change ON CONFLICT UPDATE
Date: Wed, 26 Nov 2025 10:52:10 +0100
Message-ID: <02b43e62e62eecb352c4f64bb1bedfdec11bb3ac.camel@cybertec.at> (raw)
In-Reply-To: <CACJufxEW1RRDD9ZWGcW_Np_Z9VGPE-YC7u0C6RcsEY8EKiTdBg@mail.gmail.com>
References: <CACJufxEW1RRDD9ZWGcW_Np_Z9VGPE-YC7u0C6RcsEY8EKiTdBg@mail.gmail.com>
On Tue, 2025-11-25 at 22:47 +0800, jian he wrote:
> in doc/src/sgml/ref/create_view.sgml,
> I want change two occurrences of
> <literal>ON CONFLICT UPDATE</literal>
> to
> <literal>ON CONFLICT DO UPDATE</literal>
> (between line 412 to line 439).
>
> since other places using <literal>ON CONFLICT DO UPDATE</literal>.
+1
It is not very important, but consistency is always good.
Here is a patch for that.
Yours,
Laurenz Albe
Attachments:
[text/x-patch] v1-0001-Doc-use-ON-CONFLICT-DO-UPDATE-everywhere.patch (1.9K, 2-v1-0001-Doc-use-ON-CONFLICT-DO-UPDATE-everywhere.patch)
download | inline diff:
From d33e095ee9821d8cd55836c98c083502fee2e932 Mon Sep 17 00:00:00 2001
From: Laurenz Albe <laurenz.albe@cybertec.at>
Date: Wed, 26 Nov 2025 10:49:51 +0100
Subject: [PATCH v1] Doc: use ON CONFLICT DO UPDATE everywhere
Two places in the CREATE VIEW reference page used
ON CONFLICT UPDATE instead. Better be consistent.
Author: Laurenz Albe <laurenz.albe@cybertec.at>
Reported-By: jian he <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxEW1RRDD9ZWGcW_Np_Z9VGPE-YC7u0C6RcsEY8EKiTdBg%40mail.gmail.com
---
doc/src/sgml/ref/create_view.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/ref/create_view.sgml b/doc/src/sgml/ref/create_view.sgml
index 7b6b750c6de..f8a4740608a 100644
--- a/doc/src/sgml/ref/create_view.sgml
+++ b/doc/src/sgml/ref/create_view.sgml
@@ -415,7 +415,7 @@ CREATE VIEW vista AS SELECT text 'Hello World' AS hello;
<command>DELETE</command>, or <command>MERGE</command> statement
on the view into the corresponding statement on the underlying base
relation. <command>INSERT</command> statements that have an <literal>ON
- CONFLICT UPDATE</literal> clause are fully supported.
+ CONFLICT DO UPDATE</literal> clause are fully supported.
</para>
<para>
@@ -430,7 +430,7 @@ CREATE VIEW vista AS SELECT text 'Hello World' AS hello;
an <command>INSERT</command> or <command>MERGE</command> command can
potentially insert base-relation rows
that do not satisfy the <literal>WHERE</literal> condition and thus are not
- visible through the view (<literal>ON CONFLICT UPDATE</literal> may
+ visible through the view (<literal>ON CONFLICT DO UPDATE</literal> may
similarly affect an existing row not visible through the view).
The <literal>CHECK OPTION</literal> may be used to prevent
<command>INSERT</command>, <command>UPDATE</command>, and
--
2.51.1
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: laurenz.albe@cybertec.at, jian.universality@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: change ON CONFLICT UPDATE
In-Reply-To: <02b43e62e62eecb352c4f64bb1bedfdec11bb3ac.camel@cybertec.at>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox