public inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Reject degenerate SPLIT PARTITION with DEFAULT partition
Date: Wed, 20 May 2026 11:45:51 +0000
Message-ID: <E1wPfN1-000OT2-26@gemulon.postgresql.org> (raw)

Reject degenerate SPLIT PARTITION with DEFAULT partition

ALTER TABLE ... SPLIT PARTITION allows a DEFAULT partition to be created
as one of the replacement partitions when the parent table does not
already have one.  However, it should not allow the degenerate case where
a non-DEFAULT partition keeps exactly the same bound as the split
partition and the command merely adds a DEFAULT partition through the
SPLIT PARTITION path.

Detect that case by comparing the bound of the split partition with the
bound of the only non-DEFAULT replacement partition, and raise an error
when they are the same.  Users should add a DEFAULT partition directly
with CREATE TABLE ... PARTITION OF ... DEFAULT or ALTER TABLE ... ATTACH
PARTITION ... DEFAULT instead.

Author: Chao Li <lic@highgo.com>
Reviewed-by: Alexander Korotkov <aekorotkov@gmail.com>
Discussion: https://postgr.es/m/C18878AB-DEB2-4A61-9995-A035DD644B81@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d8af73010033cb8ad6c941942d6b03d74d7e4f7e

Modified Files
--------------
src/backend/partitioning/partbounds.c         | 150 ++++++++++++++++++++++++++
src/test/regress/expected/partition_split.out |  59 ++++++++++
src/test/regress/sql/partition_split.sql      |  52 +++++++++
3 files changed, 261 insertions(+)



reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Reject degenerate SPLIT PARTITION with DEFAULT partition
  In-Reply-To: <E1wPfN1-000OT2-26@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox