MIME-Version: 1.0
References: <19476-bd04ea6241345303@postgresql.org>
 <CAJTYsWVuNPbqS2p1gEitRLBHuytqM7OMawuzVH6g4uqGw4RBsQ@mail.gmail.com>
 <1357efa6-dddb-4e60-ba6f-e88d03a4e010@gmail.com>
 <CAJTYsWWh5qsJcLatT5HD9daTEbCnZUZoqaDPGiT=+EyHkEKJ2A@mail.gmail.com>
 <agXx84rrzKWY9aAE@nathan> <agX8Olw7JnK7o9se@nathan>
In-Reply-To: <agX8Olw7JnK7o9se@nathan>
From: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Date: Thu, 14 May 2026 22:42:07 +0530
Message-ID: 
 <CAJTYsWWWeQvL0JaLYArnunhKfX6=g3q1Mjq_ViipW6G011dfpQ@mail.gmail.com>
Subject: Re: BUG #19476: Segmentation fault in contrib/spi
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: pierre.forstmann@gmail.com, pgsql-bugs@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000d2a6270651ca3260"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJTYsWWWeQvL0JaLYArnunhKfX6%3Dg3q1Mjq_ViipW6G011dfpQ%40mail.gmail.com>
Precedence: bulk

--000000000000d2a6270651ca3260
Content-Type: text/plain; charset="UTF-8"

Hi,

On Thu, 14 May 2026 at 22:15, Nathan Bossart <nathandbossart@gmail.com>
wrote:

> On Thu, May 14, 2026 at 11:01:55AM -0500, Nathan Bossart wrote:
> > Regarding 0001, note that the refint docs state the following:
> >
> >     Note that the primary/unique key columns should be marked NOT NULL
> and
> >     should have a unique index.
> >
> > So maybe we could alternatively teach check_foreign_key() to either ERROR
> > or do nothing instead.  On the other hand, given this case seemed to
> > accidentally work before the CVE fix, it's arguably worth fixing.
>
> Here is what I have staged for commit, which I intend to do shortly.
>
>
Thanks, this version looks good to me.  The compact form is fine, and I
agree with preserving the pre-CVE behavior for this misconfigured case
rather than turning it into an ERROR or no-op.

I also agree with your earlier point about the parameterized 0002: using
the triggered relation's key types for parameters is not generally right
for the referencing relation's SET targets.

I think the cached cascade UPDATE plan issue is worth pursuing,
I'll start a different hackers thread on that
probably using the "don't cache cascade UPDATE plans" approach you
suggested.

Regards,
Ayush

--000000000000d2a6270651ca3260
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi,<div><br></div></div><div class=3D"gma=
il_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Th=
u, 14 May 2026 at 22:15, Nathan Bossart &lt;<a href=3D"mailto:nathandbossar=
t@gmail.com">nathandbossart@gmail.com</a>&gt; wrote:<br></div><blockquote c=
lass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px soli=
d rgb(204,204,204);padding-left:1ex">On Thu, May 14, 2026 at 11:01:55AM -05=
00, Nathan Bossart wrote:<br>
&gt; Regarding 0001, note that the refint docs state the following:<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0Note that the primary/unique key columns should be =
marked NOT NULL and<br>
&gt;=C2=A0 =C2=A0 =C2=A0should have a unique index.<br>
&gt; <br>
&gt; So maybe we could alternatively teach check_foreign_key() to either ER=
ROR<br>
&gt; or do nothing instead.=C2=A0 On the other hand, given this case seemed=
 to<br>
&gt; accidentally work before the CVE fix, it&#39;s arguably worth fixing.<=
br>
<br>
Here is what I have staged for commit, which I intend to do shortly.<br><br=
></blockquote><div><br></div>Thanks, this version looks good to me.=C2=A0 T=
he compact form is fine, and I<br>agree with preserving the pre-CVE behavio=
r for this misconfigured case<br>rather than turning it into an ERROR or no=
-op.<br><br>I also agree with your earlier point about the parameterized 00=
02: using<br>the triggered relation&#39;s key types for parameters is not g=
enerally right<br>for the referencing relation&#39;s SET targets. =C2=A0</d=
iv><div class=3D"gmail_quote gmail_quote_container"><br></div><div class=3D=
"gmail_quote gmail_quote_container">I think the cached cascade UPDATE plan =
issue is worth pursuing,<br>I&#39;ll start a different hackers thread on th=
at=C2=A0<br>probably using the &quot;don&#39;t cache cascade UPDATE plans&q=
uot; approach you<br>suggested.<br><br>Regards,<br><div>Ayush=C2=A0</div></=
div></div>

--000000000000d2a6270651ca3260--