MIME-Version: 1.0
References: <19354-eefe6d8b3e84f9f2@postgresql.org> <CA+TgmoaRGSezRaA7x00X495Qho8WGTzggbDSUt-JsruXceZWug@mail.gmail.com>
 <CA+zULE4L4rA2DLAcfy=eQL7w_ZexV4P5zpQRbP=_qrhJBEOzjg@mail.gmail.com>
 <2292889.1765846569@sss.pgh.pa.us> <CAE2r8H5vaSyaC_t1FcpHBo-BB_=SrFj7GFnOC-SxC6WDf5c9VA@mail.gmail.com>
 <CA+zULE47EXZOp7qKYODd+mjSgDiR-WX5ZNBkwdKnj-Zc0FT58w@mail.gmail.com>
 <CA+TgmoZaoc37ohnhF5inoPxWzfoznV483xQw8Fmw+ELFScv47g@mail.gmail.com>
 <2393116.1765899706@sss.pgh.pa.us> <CA+TgmoaoW4F2rRzYcQQim9ddT4-6H3oi0UYV9Ucw-rRQ5MdHsg@mail.gmail.com>
 <CA+hUKGKy-ViGBXdOjcPownBM=OdWiULO8H1RyH1r_8qNp=U4CA@mail.gmail.com>
 <6a8122ac-123d-4e93-9269-0b3be1e4a5a4@iki.fi> <CAAAe_zCLVunjt1u+2E86shwc3hk1x4bzUyU86nY1fq-nAVYN0Q@mail.gmail.com>
 <CA+hUKGJMrcS=hBkqVk=5pjM4w8edG=_ArASC82RqB6HQro-v-g@mail.gmail.com> <CAAAe_zCwaccH7h+GOtHbo_docCY-o0c5NMRuYkdz15f=KL4f0g@mail.gmail.com>
In-Reply-To: <CAAAe_zCwaccH7h+GOtHbo_docCY-o0c5NMRuYkdz15f=KL4f0g@mail.gmail.com>
Reply-To: assam258@gmail.com
From: Henson Choi <assam258@gmail.com>
Date: Wed, 15 Apr 2026 14:57:50 +0900
Message-ID: <CAAAe_zAFz1v-3b7Je4L+=wZM3UGAczXV47YVZfZi9wbJxspxeA@mail.gmail.com>
Subject: Re: BUG #19354: JOHAB rejects valid byte sequences
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, 
	Jeroen Vermeulen <jtvjtv@gmail.com>, VASUKI M <vasukianand0119@gmail.com>, 
	pgsql-bugs@lists.postgresql.org
Content-Type: multipart/mixed; boundary="0000000000000e63c9064f79667a"
Archived-At: <https://www.postgresql.org/message-id/CAAAe_zAFz1v-3b7Je4L%2B%3DwZM3UGAczXV47YVZfZi9wbJxspxeA%40mail.gmail.com>
Precedence: bulk

--0000000000000e63c9064f79667a
Content-Type: multipart/alternative; boundary="0000000000000e63c8064f796678"

--0000000000000e63c8064f796678
Content-Type: text/plain; charset="UTF-8"

Subject: Fix and expand comments for Korean encodings in encnames.c

Hi hackers,

While reading through the encoding alias table in src/common/encnames.c,
I noticed a few long-standing inaccuracies and omissions in the per-entry
comments for the three Korean encodings.

The most visible issue is the JOHAB entry, whose comment describes it as
"Extended Unix Code for simplified Chinese" -- apparently a copy/paste
slip from a neighboring EUC entry.  JOHAB is in fact the Korean
combining-style encoding defined in KS X 1001 annex 3.

The attached 0002 patch makes comment-only adjustments to the three
Korean encodings:

  * JOHAB: replace the incorrect "simplified Chinese" description with
    a correct one that identifies it as the Korean combining (Johab)
    encoding standardized in KS X 1001 annex 3.

  * EUC_KR: drop a stray space before the comma in the existing
    comment, and note that the encoding covers the KS X 1001
    precomposed (Wansung) form.

  * UHC: spell out "Unified Hangul Code", clarify that it is
    Microsoft Windows CodePage 949, and describe its relationship to
    EUC-KR (superset covering all 11,172 precomposed Hangul syllables).

No behavior change, no catalog change, no pg_wchar.h change -- this
touches comments in src/common/encnames.c only.  pgindent is clean.

Thanks,
Henson Choi

--0000000000000e63c8064f796678
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Subject: Fix and expand comments for Korean encodings in e=
ncnames.c<br><br>Hi hackers,<br><br>While reading through the encoding alia=
s table in src/common/encnames.c,<br>I noticed a few long-standing inaccura=
cies and omissions in the per-entry<br>comments for the three Korean encodi=
ngs.<br><br>The most visible issue is the JOHAB entry, whose comment descri=
bes it as<br>&quot;Extended Unix Code for simplified Chinese&quot; -- appar=
ently a copy/paste<br>slip from a neighboring EUC entry.=C2=A0 JOHAB is in =
fact the Korean<br>combining-style encoding defined in KS X 1001 annex 3.<b=
r><br>The attached 0002 patch makes comment-only adjustments to the three<b=
r>Korean encodings:<br><br>=C2=A0 * JOHAB: replace the incorrect &quot;simp=
lified Chinese&quot; description with<br>=C2=A0 =C2=A0 a correct one that i=
dentifies it as the Korean combining (Johab)<br>=C2=A0 =C2=A0 encoding stan=
dardized in KS X 1001 annex 3.<br><br>=C2=A0 * EUC_KR: drop a stray space b=
efore the comma in the existing<br>=C2=A0 =C2=A0 comment, and note that the=
 encoding covers the KS X 1001<br>=C2=A0 =C2=A0 precomposed (Wansung) form.=
<br><br>=C2=A0 * UHC: spell out &quot;Unified Hangul Code&quot;, clarify th=
at it is<br>=C2=A0 =C2=A0 Microsoft Windows CodePage 949, and describe its =
relationship to<br>=C2=A0 =C2=A0 EUC-KR (superset covering all 11,172 preco=
mposed Hangul syllables).<br><br>No behavior change, no catalog change, no =
pg_wchar.h change -- this<br>touches comments in src/common/encnames.c only=
. =C2=A0pgindent is clean.<br><br>Thanks,<br>Henson Choi</div>

--0000000000000e63c8064f796678--
--0000000000000e63c9064f79667a
Content-Type: text/plain; charset="US-ASCII"; 
	name="0002-Fix-and-expand-comments-for-Korean-encodings.txt"
Content-Disposition: attachment; 
	filename="0002-Fix-and-expand-comments-for-Korean-encodings.txt"
Content-Transfer-Encoding: base64
Content-ID: <f_mnzn1x1e0>
X-Attachment-Id: f_mnzn1x1e0

RnJvbSBjN2E3MzM1ZDJjZjVhMjg4MWIyNWQ5MDkxZmQwMjBhMmQ2MmY3NjYxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5zb24gQ2hvaSA8YXNzYW0yNThAZ21haWwuY29tPgpEYXRl
OiBXZWQsIDE1IEFwciAyMDI2IDE0OjUyOjM1ICswOTAwClN1YmplY3Q6IFtQQVRDSCB2MV0gRml4
IGFuZCBleHBhbmQgY29tbWVudHMgZm9yIEtvcmVhbiBlbmNvZGluZ3MgaW4gZW5jbmFtZXMuYwoK
LS0tCiBzcmMvY29tbW9uL2VuY25hbWVzLmMgfCAxMyArKysrKysrKy0tLS0tCiAxIGZpbGUgY2hh
bmdlZCwgOCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9j
b21tb24vZW5jbmFtZXMuYyBiL3NyYy9jb21tb24vZW5jbmFtZXMuYwppbmRleCA5MDg1ZGJlY2Nl
MS4uOTU5Yjk5MWRkZTQgMTAwNjQ0Ci0tLSBhL3NyYy9jb21tb24vZW5jbmFtZXMuYworKysgYi9z
cmMvY29tbW9uL2VuY25hbWVzLmMKQEAgLTYxLDggKzYxLDkgQEAgc3RhdGljIGNvbnN0IHBnX2Vu
Y25hbWUgcGdfZW5jbmFtZV90YmxbXSA9CiAJCQkJCQkJCSAqIEphcGFuZXNlLCBzdGFuZGFyZCBP
U0YgKi8KIAl7CiAJCSJldWNrciIsIFBHX0VVQ19LUgotCX0sCQkJCQkJCS8qIEVVQy1LUjsgRXh0
ZW5kZWQgVW5peCBDb2RlIGZvciBLb3JlYW4gLCBLUwotCQkJCQkJCQkgKiBYIDEwMDEgc3RhbmRh
cmQgKi8KKwl9LAkJCQkJCQkvKiBFVUMtS1I7IEV4dGVuZGVkIFVuaXggQ29kZSBmb3IgS29yZWFu
CisJCQkJCQkJCSAqIHByZWNvbXBvc2VkIChXYW5zdW5nKSBlbmNvZGluZywgc3RhbmRhcmQgS1MK
KwkJCQkJCQkJICogWCAxMDAxICovCiAJewogCQkiZXVjdHciLCBQR19FVUNfVFcKIAl9LAkJCQkJ
CQkvKiBFVUMtVFc7IEV4dGVuZGVkIFVuaXggQ29kZSBmb3IKQEAgLTExOSw4ICsxMjAsOCBAQCBz
dGF0aWMgY29uc3QgcGdfZW5jbmFtZSBwZ19lbmNuYW1lX3RibFtdID0KIAl9LAkJCQkJCQkvKiBJ
U08tODg1OS05OyBSRkMxMzQ1LEtYUzIgKi8KIAl7CiAJCSJqb2hhYiIsIFBHX0pPSEFCCi0JfSwJ
CQkJCQkJLyogSk9IQUI7IEV4dGVuZGVkIFVuaXggQ29kZSBmb3Igc2ltcGxpZmllZAotCQkJCQkJ
CQkgKiBDaGluZXNlICovCisJfSwJCQkJCQkJLyogSk9IQUI7IEtvcmVhbiBjb21iaW5pbmcgKEpv
aGFiKSBlbmNvZGluZywKKwkJCQkJCQkJICogc3RhbmRhcmQgS1MgWCAxMDAxIGFubmV4IDMgKi8K
IAl7CiAJCSJrb2k4IiwgUEdfS09JOFIKIAl9LAkJCQkJCQkvKiBfZGlydHlfIGFsaWFzIGZvciBL
T0k4LVIgKGJhY2t3YXJkCkBAIC0xODYsNyArMTg3LDkgQEAgc3RhdGljIGNvbnN0IHBnX2VuY25h
bWUgcGdfZW5jbmFtZV90YmxbXSA9CiAJfSwJCQkJCQkJLyogYWxpYXMgZm9yIFdJTjEyNTggKi8K
IAl7CiAJCSJ1aGMiLCBQR19VSEMKLQl9LAkJCQkJCQkvKiBVSEM7IEtvcmVhbiBXaW5kb3dzIENv
ZGVQYWdlIDk0OSAqLworCX0sCQkJCQkJCS8qIFVIQzsgVW5pZmllZCBIYW5ndWwgQ29kZSwgTWlj
cm9zb2Z0IFdpbmRvd3MKKwkJCQkJCQkJICogQ29kZVBhZ2UgOTQ5OyBzdXBlcnNldCBvZiBFVUMt
S1IgY292ZXJpbmcKKwkJCQkJCQkJICogYWxsIDExLDE3MiBwcmVjb21wb3NlZCBIYW5ndWwgc3ls
bGFibGVzICovCiAJewogCQkidW5pY29kZSIsIFBHX1VURjgKIAl9LAkJCQkJCQkvKiBhbGlhcyBm
b3IgVVRGOCAqLwotLSAKMi41MC4xIChBcHBsZSBHaXQtMTU1KQoK
--0000000000000e63c9064f79667a--