public inbox for pgsql-bugs@postgresql.org
help / color / mirror / Atom feedFrom: Jeroen Vermeulen <jtvjtv@gmail.com>
To: VASUKI M <vasukianand0119@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19354: JOHAB rejects valid byte sequences
Date: Tue, 16 Dec 2025 08:42:09 +0100
Message-ID: <CA+zULE47EXZOp7qKYODd+mjSgDiR-WX5ZNBkwdKnj-Zc0FT58w@mail.gmail.com> (raw)
In-Reply-To: <CAE2r8H5vaSyaC_t1FcpHBo-BB_=SrFj7GFnOC-SxC6WDf5c9VA@mail.gmail.com>
References: <19354-eefe6d8b3e84f9f2@postgresql.org>
<CA+TgmoaRGSezRaA7x00X495Qho8WGTzggbDSUt-JsruXceZWug@mail.gmail.com>
<CA+zULE4L4rA2DLAcfy=eQL7w_ZexV4P5zpQRbP=_qrhJBEOzjg@mail.gmail.com>
<2292889.1765846569@sss.pgh.pa.us>
<CAE2r8H5vaSyaC_t1FcpHBo-BB_=SrFj7GFnOC-SxC6WDf5c9VA@mail.gmail.com>
My one worry is perhaps Johab is on the list because one important user
needed it.
But even then that requirement may have gone away?
Jeroen
On Tue, Dec 16, 2025, 07:23 VASUKI M <vasukianand0119@gmail.com> wrote:
> Thanks all,That analysis makes a lot of sense.
>
> Given the lack of a clear spec,the existence of multiple JOHAB
> variants,and how long this has apparently been "working" without anyone
> noticing,IMHO desupporting it does seem like the least risky option.At this
> point,trying to fix JOHAB variants feels like opening a pretty big can of
> worms,especially with the potential for dump/reload surprises or subtle
> parsing/security issues.
>
> I don't have additional data to add,but +1 on removal or deprecation being
> a reasonable outcome here,given how obscure and effectively dead the
> encoding is nowadays.
>
> Thanks for digging into this.
>
> Cheers,
> Vasuki M
>
> On Tue, Dec 16, 2025 at 11:46 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
>> Jeroen Vermeulen <jtvjtv@gmail.com> writes:
>> > This bit worries me: "TlOther, vendor-defined, Johab variants also
>> exist" —
>> > such as an EBCDIC-based one and a stateful one!
>>
>> Yeah. So what we have here is:
>>
>> 1. Our JOHAB implementation has apparently been wrong since day one.
>>
>> 2. Wrongness may be in the eye of the beholder, since there are
>> multiple versions of JOHAB.
>>
>> 3. Your complaint is the first, AFAIR.
>>
>> 4. That wikipedia page says "Following the introduction of Unified
>> Hangul Code by Microsoft in Windows 95, and Hangul Word Processor
>> abandoning Johab in favour of Unicode in 2000, Johab ceased to be
>> commonly used."
>>
>> Given these things, I wonder if we shouldn't desupport JOHAB
>> rather than attempt to fix it. Fixing would likely be a significant
>> amount of work: if we don't even have the character lengths right,
>> how likely is it that our conversions to other character sets are
>> correct? I also worry that if different PG versions have different
>> ideas of the mapping, there could be room for dump/reload problems,
>> and maybe even security problems related to the backslash issue.
>>
>> regards, tom lane
>>
>>
>>
>>
>>
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: jtvjtv@gmail.com, vasukianand0119@gmail.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19354: JOHAB rejects valid byte sequences
In-Reply-To: <CA+zULE47EXZOp7qKYODd+mjSgDiR-WX5ZNBkwdKnj-Zc0FT58w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox