From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeroen Vermeulen <jtvjtv@gmail.com>
cc: Robert Haas <robertmhaas@gmail.com>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19354: JOHAB rejects valid byte sequences
In-reply-to: <CA+zULE4L4rA2DLAcfy=eQL7w_ZexV4P5zpQRbP=_qrhJBEOzjg@mail.gmail.com>
References: <19354-eefe6d8b3e84f9f2@postgresql.org> <CA+TgmoaRGSezRaA7x00X495Qho8WGTzggbDSUt-JsruXceZWug@mail.gmail.com> <CA+zULE4L4rA2DLAcfy=eQL7w_ZexV4P5zpQRbP=_qrhJBEOzjg@mail.gmail.com>
Comments: In-reply-to Jeroen Vermeulen <jtvjtv@gmail.com>
	message dated "Tue, 16 Dec 2025 01:07:12 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <2292888.1765846569.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 15 Dec 2025 19:56:09 -0500
Message-ID: <2292889.1765846569@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2292889.1765846569%40sss.pgh.pa.us>
Precedence: bulk

Jeroen Vermeulen <jtvjtv@gmail.com> writes:
> This bit worries me: "TlOther, vendor-defined, Johab variants also exist=
" =E2=80=94
> such as an EBCDIC-based one and a stateful one!

Yeah.  So what we have here is:

1. Our JOHAB implementation has apparently been wrong since day one.

2. Wrongness may be in the eye of the beholder, since there are
multiple versions of JOHAB.

3. Your complaint is the first, AFAIR.

4. That wikipedia page says "Following the introduction of Unified
Hangul Code by Microsoft in Windows 95, and Hangul Word Processor
abandoning Johab in favour of Unicode in 2000, Johab ceased to be
commonly used."

Given these things, I wonder if we shouldn't desupport JOHAB
rather than attempt to fix it.  Fixing would likely be a significant
amount of work: if we don't even have the character lengths right,
how likely is it that our conversions to other character sets are
correct?  I also worry that if different PG versions have different
ideas of the mapping, there could be room for dump/reload problems,
and maybe even security problems related to the backslash issue.

			regards, tom lane