Sender: owner-postgres95@postgres.Berkeley.EDU X-Return-Path: andrew_yu Received: from park.interport.net (park.interport.net [199.184.165.2]) by nobozo.CS.Berkeley.EDU (8.6.10/8.6.3) with ESMTP id JAA29505 for ; Tue, 7 Nov 1995 09:12:54 -0800 Received: from interport.net (madison.nfs.interport.net [205.161.144.1]) by park.interport.net (8.6.11/8.6.11) with ESMTP id MAA06813; Tue, 7 Nov 1995 12:12:48 -0500 Received: (from jamiec@localhost) by interport.net (8.6.10/8.6.10) id MAA08648; Tue, 7 Nov 1995 12:12:43 -0500 Date: Tue, 7 Nov 1995 12:12:42 -0500 (EST) From: jamie cohan To: "Andrew K. Yu" cc: postgres95@postgres.Berkeley.EDU Subject: Re: Is there a reason that DECLARE .. GROUP BY was not implemented In-Reply-To: <199511070637.WAA16808@eden.CS.Berkeley.EDU> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Resent-To: postgres95-redist Resent-Date: Tue, 07 Nov 95 09:12:55 -0800 Resent-From: pglite Resent-XMts: smtp Thanks Andrew I will begin working on it today if all goes well I will have a patch by tomorrow. Is there anything else that you think I will need to modify. On Mon, 6 Nov 1995, Andrew K. Yu wrote: > > > Was there a reason that the followin statement " DECLARE mycursor cursor for > > select sum(a) from test group by a;" was not implemented. I have > > there is no inherent reason other than not enough time. (I don't know how many > people noticed but if you ever look at the postgres 4.2 code, you'll see tons > of LispValue in the parser which makes doing something simple like what jamie > did in the following impossible to do. And converting postgres' internals to > use the new data structures took up a significant amount of time.) > > > modified 'gram.y' to allow for 'group_clause' and n->groupClause in the > > CursorStmt structure and modified 'nodes/parsernodes.h' to have a > > LList * groupClause. What else should I modify to get this functionality. > > you also need to modify transformCursorStmt in parser/analyze.c (add > a transformGroupBy call like what transformSelect did.) > > -andrew > > =============================================================================== > To unsubscribe from the Postgres95 mailing list, send mail with the subject > line "DEL" to "postgres95-request@postgres.Berkeley.EDU". > ============ URL: http://s2k-ftp.CS.Berkeley.EDU:8000/postgres95/ =========== > =============================================================================== To unsubscribe from the Postgres95 mailing list, send mail with the subject line "DEL" to "postgres95-request@postgres.Berkeley.EDU". ============ URL: http://s2k-ftp.CS.Berkeley.EDU:8000/postgres95/ ===========